From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: Jeremy Spewock <jspewock@iol.unh.edu>
Cc: paul.szczepanek@arm.com, Honnappa.Nagarahalli@arm.com,
probb@iol.unh.edu, alex.chapman@arm.com, thomas@monjalon.net,
Luca.Vizzarro@arm.com, npratte@iol.unh.edu,
yoan.picchi@foss.arm.com, wathsala.vithanage@arm.com,
dev@dpdk.org
Subject: Re: [PATCH v2 1/1] dts: add send_packets to test suites and rework packet addressing
Date: Thu, 26 Sep 2024 09:52:08 +0200 [thread overview]
Message-ID: <bfd384d9-5320-45e2-ba33-646d9643dca3@pantheon.tech> (raw)
In-Reply-To: <CAAA20UShw9ESNUG6dj1bH6LuLj459dwHQLQsme-Q3ApQJb8jEw@mail.gmail.com>
>>> + if num_ip_layers > 0:
>>> + ip_src_is_unset = "src" not in l3_to_use.fields
>>> + ip_dst_is_unset = "dst" not in l3_to_use.fields
>>> + else:
>>> + ip_src_is_unset = None
>>> + ip_dst_is_unset = None
>>>
>>> - # The packet is routed from TG egress to TG ingress
>>> - # update l3 addresses
>>> - packet.payload.src = self._tg_ip_address_egress.ip.exploded
>>> - packet.payload.dst = self._tg_ip_address_ingress.ip.exploded
>>> - else:
>>> - # The packet leaves TG towards SUT
>>> # update l2 addresses
>>> - packet.src = self._tg_port_egress.mac_address
>>> - packet.dst = self._sut_port_ingress.mac_address
>>> + # If `expected` is :data:`True`, the packet enters the TG from SUT, otherwise the
>>> + # packet leaves the TG towards the SUT
>>> + if pkt_src_is_unset:
>>> + packet.src = (
>>> + self._sut_port_egress.mac_address
>>> + if expected
>>> + else self._tg_port_egress.mac_address
>>> + )
>>> + if pkt_dst_is_unset:
>>> + packet.dst = (
>>> + self._tg_port_ingress.mac_address
>>> + if expected
>>> + else self._sut_port_ingress.mac_address
>>> + )
>>>
>>> - # The packet is routed from TG egress to TG ingress
>>> # update l3 addresses
>>> - packet.payload.src = self._tg_ip_address_egress.ip.exploded
>>> - packet.payload.dst = self._tg_ip_address_ingress.ip.exploded
>>> + # The packet is routed from TG egress to TG ingress regardless of whether it is
>>> + # expected or not.
>>
>> Is this true? This might've been an error in the original
>> implementation. If it's expected (that is, the returning packet), it
>> should be routed from TG ingress to TG egress, no?
>
> I guess I'm not completely sure. It would make sense that the L3
> addresses should be switched as well based on either expected or not,
> but currently it isn't modified, and os_udp still works which makes me
> think the addresses aren't switched by the kernel interfaces, which I
> believe is the only time these addresses are actually used (since we
> use sendp in scapy).
>
Right, I went too deep in my thinking and confused myself :-). The path
of the packet is:
TG egress -> SUT ingress -> SUT egress -> TG ingress
That is just one way path and I mixed the other direction into my
thinking as well. With just one path, the MAC addresses are going to
change, but not IP addresses.
next prev parent reply other threads:[~2024-09-26 7:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 15:28 [PATCH v1 0/1] dts: adjust packet addressing and sending jspewock
2024-09-04 15:28 ` [PATCH v1 1/1] dts: add send_packets to test suites and rework packet addressing jspewock
2024-09-09 19:43 ` Dean Marx
2024-09-12 12:35 ` Patrick Robb
2024-09-20 18:08 ` [PATCH v2 0/1] dts: adjust packet addressing and sending jspewock
2024-09-20 18:08 ` [PATCH v2 1/1] dts: add send_packets to test suites and rework packet addressing jspewock
2024-09-24 14:30 ` Juraj Linkeš
2024-09-25 16:09 ` Jeremy Spewock
2024-09-26 7:52 ` Juraj Linkeš [this message]
2024-09-26 10:13 ` Juraj Linkeš
2024-09-25 18:21 ` [PATCH v3 0/1] dts: adjust " jspewock
2024-09-25 18:21 ` [PATCH v3 1/1] dts: rework " jspewock
2024-09-26 12:30 ` Juraj Linkeš
2024-09-26 17:02 ` Jeremy Spewock
2024-09-26 18:06 ` [PATCH v4 0/1] dts: adjust " jspewock
2024-09-26 18:06 ` [PATCH v4 1/1] dts: rework " jspewock
2024-09-26 18:18 ` [PATCH v5 0/2] dts: adjust packet addressing and add send_packets to test_suite jspewock
2024-09-26 18:18 ` [PATCH v5 1/2] dts: rework packet addressing jspewock
2024-09-27 9:46 ` Juraj Linkeš
2024-09-27 11:46 ` Luca Vizzarro
2024-09-26 18:18 ` [PATCH v5 2/2] dts: add send_packets to test_suite jspewock
2024-09-27 11:46 ` Luca Vizzarro
2024-09-30 13:40 ` [PATCH v5 0/2] dts: adjust packet addressing and " Juraj Linkeš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfd384d9-5320-45e2-ba33-646d9643dca3@pantheon.tech \
--to=juraj.linkes@pantheon.tech \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Luca.Vizzarro@arm.com \
--cc=alex.chapman@arm.com \
--cc=dev@dpdk.org \
--cc=jspewock@iol.unh.edu \
--cc=npratte@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=thomas@monjalon.net \
--cc=wathsala.vithanage@arm.com \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).