From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F87CA0561; Wed, 17 Mar 2021 19:05:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC997140E6A; Wed, 17 Mar 2021 19:05:17 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 4DF4A140E1D for ; Wed, 17 Mar 2021 19:05:15 +0100 (CET) IronPort-SDR: pwOzHdAc9IdQLiviidHaqDL3Ll6Nbc6zxgqj02U9IvLQFMf9ijUJzHvDcd8N11pMk89mkeDNWV CWNUfr2Gcqtg== X-IronPort-AV: E=McAfee;i="6000,8403,9926"; a="250876062" X-IronPort-AV: E=Sophos;i="5.81,257,1610438400"; d="scan'208";a="250876062" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 11:05:03 -0700 IronPort-SDR: s75EK8UP/xBU3Yc2JrPoAaoUc7CbA/gOgYnawSuzzTRTEu1dXNBpzDCnzPyPXhOP+ymWpxNZo8 f8eCAgBBeUbA== X-IronPort-AV: E=Sophos;i="5.81,257,1610438400"; d="scan'208";a="406027581" Received: from mmansoor-mobl.ger.corp.intel.com (HELO [10.252.22.40]) ([10.252.22.40]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 11:05:02 -0700 To: Viacheslav Ovsiienko , dev@dpdk.org Cc: rasland@nvidia.com, matan@nvidia.com, orika@nvidia.com References: <20210307100251.22538-1-viacheslavo@nvidia.com> <20210314121302.5988-1-viacheslavo@nvidia.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Wed, 17 Mar 2021 18:04:58 +0000 MIME-Version: 1.0 In-Reply-To: <20210314121302.5988-1-viacheslavo@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 0/5] mlx5: add timestamp format support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/14/2021 12:12 PM, Viacheslav Ovsiienko wrote: > There are two different timestamp formats can be provided potentially > by mlx5 supported hardware. > > The free-running format provides some opaque values captured from > internal clock counter clocked by some independent oscillator. > The free-running frequency is not pre-defined and should be queried > from the NIC. > > The real-time timestamps are presented in nanoseconds and captured from > the dedicated UTC counter, that can be adjusted on the fly and might be > synchronized with some external master clock. > > Depending on the version and configuration the hardware might support > either FR or RT timestamps, or both in the same time on per queue basis. > Since firmware version xx.30.0256 the timestamp format can be configured > via fields in the queue context at the object creation time. For the > compatibility reasons the default zero value configures timestamps with > free-running format. The NIC ConnectX-5 and earlier ones support the > free-running format only. Since ConnectX-6 both formats might be supported > and configured. The default zero value (specified in the non-defined > yet timestamp format context field) causes the queue creation failure > (rejected by firmware) if the NIC is configured to real-time timestamp > format. > > Hence, it is crucial to check whether firmware/hardware supports > timestamp formats and configure queues accordingly, and this patchset > also must be provided for stable DPDK releases. > > Compatibility affected (without this patchset) summary: > - ConnectX-6DX or BlueField 2 > - real-time format is configured in NV settings > - firmware is xx.30.1000 or higher > Hi Viacheslav, The patch looks like adding real time timestamp support, I was wondering why this is a fix but above already describes it, thanks for it. > Viacheslav Ovsiienko (5): > common/mlx5: add timestamp format support to DevX > net/mlx5: add timestamp format support > vdpa/mlx5: add timestamp format support > regex/mlx5: add timestamp format support > compress/mlx5: add timestamp format support > > drivers/common/mlx5/mlx5_devx_cmds.c | 35 ++++++++++++++-- > drivers/common/mlx5/mlx5_devx_cmds.h | 7 ++++ > drivers/common/mlx5/mlx5_prm.h | 55 +++++++++++++++++++++++-- > drivers/compress/mlx5/mlx5_compress.c | 3 ++ > drivers/net/mlx5/linux/mlx5_os.c | 3 ++ > drivers/net/mlx5/mlx5.h | 3 ++ > drivers/net/mlx5/mlx5_devx.c | 2 +- > drivers/net/mlx5/mlx5_flow_age.c | 7 +++- > drivers/net/mlx5/mlx5_txpp.c | 2 + > drivers/net/mlx5/windows/mlx5_os.c | 3 ++ > drivers/regex/mlx5/mlx5_regex.c | 1 + > drivers/regex/mlx5/mlx5_regex.h | 1 + > drivers/regex/mlx5/mlx5_regex_control.c | 1 + > drivers/vdpa/mlx5/mlx5_vdpa.c | 1 + > drivers/vdpa/mlx5/mlx5_vdpa.h | 1 + > drivers/vdpa/mlx5/mlx5_vdpa_event.c | 2 + > 16 files changed, 117 insertions(+), 10 deletions(-) >