[Bug 1066] [dpdk20.11.6-rc1] dpdk20.11.6-rc1 compiled failed with kmods enable

[Bug 1066] [dpdk20.11.6-rc1] dpdk20.11.6-rc1 compiled failed with kmods enable

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=1066

            Bug ID: 1066
           Summary: [dpdk20.11.6-rc1] dpdk20.11.6-rc1 compiled failed with
                    kmods enable
           Product: DPDK
           Version: 20.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: testpmd
          Assignee: dev@dpdk.org
          Reporter: weiyuanx.li@intel.com
  Target Milestone: ---

[Environment]
DPDK version: Use make showversion or for a non-released version: git remote -v
&& git show-ref --heads
 dpdk 20.11.6-rc1 c5dc4f6eb5718da16cad951784242edfa26eb578
Other software versions: name/version for QEMU, OVS, etc. Repeat as required.
OS: Ubuntu 18.04.6 LTS/4.15.0-76-generic
Compiler: gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
Hardware platform: Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz
NIC hardware: Ethernet Controller XXV710 for 25GbE SFP28 158b
NIC firmware: i40e-2.14.13/firmware-version: 8.00 0x80008c1a 1.2766.0

[Test Setup]
Steps to reproduce
List the steps to reproduce the issue.

1. rm -rf x86_64-native-linuxapp-gcc

2. CC=gcc meson -Denable_kmods=True -Dlibdir=lib  --default-library=static
x86_64-native-linuxapp-gcc

3. ninja -C x86_64-native-linuxapp-gcc -j 70

[Show the output from the previous commands.]

compiled failed.

Found ninja-1.10.2.git.kitware.jobserver-1 at /usr/local/bin/ninja
NOTICE: You are using Python 3.6 which is EOL. Starting with v0.62.0, Meson
will require Python 3.7 or newer
root@test-S2600CW:~/dpdk# ninja -C x86_64-native-linuxapp-gcc -j 70
ninja: Entering directory `x86_64-native-linuxapp-gcc'
[2412/2458] Generating kernel/linux/kni/rte_kni with a custom command
FAILED: kernel/linux/kni/rte_kni.ko
/usr/bin/make -j4 -C /lib/modules/4.15.0-76-generic/build
M=/root/dpdk/x86_64-native-linuxapp-gcc/kernel/linux/kni
src=/root/dpdk/kernel/linux/kni 'MODULE_CFLAGS=  -include
/root/dpdk/config/rte_config.h -I/root/dpdk/lib/librte_eal/include
-I/root/dpdk/lib/librte_kni -I/root/dpdk/x86_64-native-linuxapp-gcc
-I/root/dpdk/kernel/linux/kni' modules
make: Entering directory '/usr/src/linux-headers-4.15.0-76-generic'
  CC [M]  /root/dpdk/x86_64-native-linuxapp-gcc/kernel/linux/kni/kni_net.o
  CC [M]  /root/dpdk/x86_64-native-linuxapp-gcc/kernel/linux/kni/kni_misc.o
/root/dpdk/kernel/linux/kni/kni_net.c: In function ‘kni_net_rx_normal’:
/root/dpdk/kernel/linux/kni/kni_net.c:448:2: error: #else after #else
 #else
  ^~~~
/root/dpdk/kernel/linux/kni/kni_net.c:444:0: error: the conditional began here
 #ifdef HAVE_NETIF_RX_NI/root/dpdk/kernel/linux/kni/kni_net.c:444:0: error:
unterminated #else
/root/dpdk/kernel/linux/kni/kni_net.c:445:3: error: expected declaration or
statement at end of input
   netif_rx_ni(skb);
   ^~~~~~~~~~~
/root/dpdk/kernel/linux/kni/kni_net.c:445:3: error: expected declaration or
statement at end of input
/root/dpdk/kernel/linux/kni/kni_net.c:382:11: warning: unused variable ‘ret’
[-Wunused-variable]
  uint32_t ret;
           ^~~
At top level:
/root/dpdk/kernel/linux/kni/kni_net.c:297:1: warning: ‘kni_net_tx’ defined but
not used [-Wunused-function]
 kni_net_tx(struct sk_buff *skb, struct net_device *dev)
 ^~~~~~~~~~
/root/dpdk/kernel/linux/kni/kni_net.c:284:1: warning: ‘kni_net_config’ defined
but not used [-Wunused-function]
 kni_net_config(struct net_device *dev, struct ifmap *map)
 ^~~~~~~~~~~~~~
/root/dpdk/kernel/linux/kni/kni_net.c:202:1: warning: ‘kni_net_release’ defined
but not used [-Wunused-function]
 kni_net_release(struct net_device *dev)
 ^~~~~~~~~~~~~~~
/root/dpdk/kernel/linux/kni/kni_net.c:180:1: warning: ‘kni_net_open’ defined
but not used [-Wunused-function]
 kni_net_open(struct net_device *dev)
 ^~~~~~~~~~~~
/root/dpdk/kernel/linux/kni/kni_net.c:38:21: warning: ‘kni_net_rx_func’ defined
but not used [-Wunused-variable]
 static kni_net_rx_t kni_net_rx_func = kni_net_rx_normal;
                     ^~~~~~~~~~~~~~~
scripts/Makefile.build:330: recipe for target
'/root/dpdk/x86_64-native-linuxapp-gcc/kernel/linux/kni/kni_net.o' failed
make[1]: *** [/root/dpdk/x86_64-native-linuxapp-gcc/kernel/linux/kni/kni_net.o]
Error 1
make[1]: *** Waiting for unfinished jobs....
Makefile:1580: recipe for target
'_module_/root/dpdk/x86_64-native-linuxapp-gcc/kernel/linux/kni' failed
make: *** [_module_/root/dpdk/x86_64-native-linuxapp-gcc/kernel/linux/kni]
Error 2
make: Leaving directory '/usr/src/linux-headers-4.15.0-76-generic'
[2423/2458] Compiling C object
drivers/libtmp_rte_event_octeontx2.a.p/event_octeontx2_otx2_worker_dual.c.o
ninja: build stopped: subcommand failed.

[Expected Result]
Explain what is the expected result in text or as an example output:

Compiled successfully 

[Regression]
Is this issue a regression: (Y/N) Y

133ec0ce1cf48478423440b532eabb7bcb019c0c is the first bad commit
commit 133ec0ce1cf48478423440b532eabb7bcb019c0c
Author: Jiri Slaby <jslaby@suse.cz>
Date:   Wed Jun 1 08:53:58 2022 +0200

    kni: fix build with Linux 5.18

    [ upstream commit c98600d4bed6d15599e448990f2ba117ca938a2d ]

    Since commit 2655926aea9b (net: Remove netif_rx_any_context() and
    netif_rx_ni().) in 5.18, netif_rx_ni() no longer exists as netif_rx()
    can be called from any context. So define HAVE_NETIF_RX_NI for older
    releases and call the appropriate function in kni_net.

    netif_rx_ni() must be used on older kernel since netif_rx() might
    might lead to deadlocks or other problems there.

    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

:040000 040000 fe96635ddbb6bd32573fb831d76ec743455f4e53
40ffc05cda642a4c496d2c51023470e6ba8de467 M      kernel

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 1066] [dpdk20.11.6-rc1] dpdk20.11.6-rc1 compiled failed with kmods enable

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=1066

liweiyuan (weiyuanx.li@intel.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #4 from liweiyuan (weiyuanx.li@intel.com) ---
Patch has been merged to dpdk20.11 close this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.