From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA522A00C3; Tue, 16 Aug 2022 07:29:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F29A94068E; Tue, 16 Aug 2022 07:29:58 +0200 (CEST) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id E80934067C for ; Tue, 16 Aug 2022 07:29:57 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id CF422A00C4; Tue, 16 Aug 2022 07:29:57 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [Bug 1066] [dpdk20.11.6-rc1] dpdk20.11.6-rc1 compiled failed with kmods enable Date: Tue, 16 Aug 2022 05:29:56 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: testpmd X-Bugzilla-Version: 20.11 X-Bugzilla-Keywords: X-Bugzilla-Severity: major X-Bugzilla-Who: weiyuanx.li@intel.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org https://bugs.dpdk.org/show_bug.cgi?id=3D1066 Bug ID: 1066 Summary: [dpdk20.11.6-rc1] dpdk20.11.6-rc1 compiled failed with kmods enable Product: DPDK Version: 20.11 Hardware: All OS: All Status: UNCONFIRMED Severity: major Priority: Normal Component: testpmd Assignee: dev@dpdk.org Reporter: weiyuanx.li@intel.com Target Milestone: --- [Environment] DPDK version: Use make showversion or for a non-released version: git remot= e -v && git show-ref --heads dpdk 20.11.6-rc1 c5dc4f6eb5718da16cad951784242edfa26eb578 Other software versions: name/version for QEMU, OVS, etc. Repeat as require= d. OS: Ubuntu 18.04.6 LTS/4.15.0-76-generic Compiler: gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0 Hardware platform: Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz NIC hardware: Ethernet Controller XXV710 for 25GbE SFP28 158b NIC firmware: i40e-2.14.13/firmware-version: 8.00 0x80008c1a 1.2766.0 [Test Setup] Steps to reproduce List the steps to reproduce the issue. 1. rm -rf x86_64-native-linuxapp-gcc 2. CC=3Dgcc meson -Denable_kmods=3DTrue -Dlibdir=3Dlib --default-library= =3Dstatic x86_64-native-linuxapp-gcc 3. ninja -C x86_64-native-linuxapp-gcc -j 70 [Show the output from the previous commands.] compiled failed. Found ninja-1.10.2.git.kitware.jobserver-1 at /usr/local/bin/ninja NOTICE: You are using Python 3.6 which is EOL. Starting with v0.62.0, Meson will require Python 3.7 or newer root@test-S2600CW:~/dpdk# ninja -C x86_64-native-linuxapp-gcc -j 70 ninja: Entering directory `x86_64-native-linuxapp-gcc' [2412/2458] Generating kernel/linux/kni/rte_kni with a custom command FAILED: kernel/linux/kni/rte_kni.ko /usr/bin/make -j4 -C /lib/modules/4.15.0-76-generic/build M=3D/root/dpdk/x86_64-native-linuxapp-gcc/kernel/linux/kni src=3D/root/dpdk/kernel/linux/kni 'MODULE_CFLAGS=3D -include /root/dpdk/config/rte_config.h -I/root/dpdk/lib/librte_eal/include -I/root/dpdk/lib/librte_kni -I/root/dpdk/x86_64-native-linuxapp-gcc -I/root/dpdk/kernel/linux/kni' modules make: Entering directory '/usr/src/linux-headers-4.15.0-76-generic' CC [M] /root/dpdk/x86_64-native-linuxapp-gcc/kernel/linux/kni/kni_net.o CC [M] /root/dpdk/x86_64-native-linuxapp-gcc/kernel/linux/kni/kni_misc.o /root/dpdk/kernel/linux/kni/kni_net.c: In function =E2=80=98kni_net_rx_norm= al=E2=80=99: /root/dpdk/kernel/linux/kni/kni_net.c:448:2: error: #else after #else #else ^~~~ /root/dpdk/kernel/linux/kni/kni_net.c:444:0: error: the conditional began h= ere #ifdef HAVE_NETIF_RX_NI/root/dpdk/kernel/linux/kni/kni_net.c:444:0: error: unterminated #else /root/dpdk/kernel/linux/kni/kni_net.c:445:3: error: expected declaration or statement at end of input netif_rx_ni(skb); ^~~~~~~~~~~ /root/dpdk/kernel/linux/kni/kni_net.c:445:3: error: expected declaration or statement at end of input /root/dpdk/kernel/linux/kni/kni_net.c:382:11: warning: unused variable =E2= =80=98ret=E2=80=99 [-Wunused-variable] uint32_t ret; ^~~ At top level: /root/dpdk/kernel/linux/kni/kni_net.c:297:1: warning: =E2=80=98kni_net_tx= =E2=80=99 defined but not used [-Wunused-function] kni_net_tx(struct sk_buff *skb, struct net_device *dev) ^~~~~~~~~~ /root/dpdk/kernel/linux/kni/kni_net.c:284:1: warning: =E2=80=98kni_net_conf= ig=E2=80=99 defined but not used [-Wunused-function] kni_net_config(struct net_device *dev, struct ifmap *map) ^~~~~~~~~~~~~~ /root/dpdk/kernel/linux/kni/kni_net.c:202:1: warning: =E2=80=98kni_net_rele= ase=E2=80=99 defined but not used [-Wunused-function] kni_net_release(struct net_device *dev) ^~~~~~~~~~~~~~~ /root/dpdk/kernel/linux/kni/kni_net.c:180:1: warning: =E2=80=98kni_net_open= =E2=80=99 defined but not used [-Wunused-function] kni_net_open(struct net_device *dev) ^~~~~~~~~~~~ /root/dpdk/kernel/linux/kni/kni_net.c:38:21: warning: =E2=80=98kni_net_rx_f= unc=E2=80=99 defined but not used [-Wunused-variable] static kni_net_rx_t kni_net_rx_func =3D kni_net_rx_normal; ^~~~~~~~~~~~~~~ scripts/Makefile.build:330: recipe for target '/root/dpdk/x86_64-native-linuxapp-gcc/kernel/linux/kni/kni_net.o' failed make[1]: *** [/root/dpdk/x86_64-native-linuxapp-gcc/kernel/linux/kni/kni_ne= t.o] Error 1 make[1]: *** Waiting for unfinished jobs.... Makefile:1580: recipe for target '_module_/root/dpdk/x86_64-native-linuxapp-gcc/kernel/linux/kni' failed make: *** [_module_/root/dpdk/x86_64-native-linuxapp-gcc/kernel/linux/kni] Error 2 make: Leaving directory '/usr/src/linux-headers-4.15.0-76-generic' [2423/2458] Compiling C object drivers/libtmp_rte_event_octeontx2.a.p/event_octeontx2_otx2_worker_dual.c.o ninja: build stopped: subcommand failed. [Expected Result] Explain what is the expected result in text or as an example output: Compiled successfully=20 [Regression] Is this issue a regression: (Y/N) Y 133ec0ce1cf48478423440b532eabb7bcb019c0c is the first bad commit commit 133ec0ce1cf48478423440b532eabb7bcb019c0c Author: Jiri Slaby Date: Wed Jun 1 08:53:58 2022 +0200 kni: fix build with Linux 5.18 [ upstream commit c98600d4bed6d15599e448990f2ba117ca938a2d ] Since commit 2655926aea9b (net: Remove netif_rx_any_context() and netif_rx_ni().) in 5.18, netif_rx_ni() no longer exists as netif_rx() can be called from any context. So define HAVE_NETIF_RX_NI for older releases and call the appropriate function in kni_net. netif_rx_ni() must be used on older kernel since netif_rx() might might lead to deadlocks or other problems there. Signed-off-by: Jiri Slaby Reviewed-by: Andrew Rybchenko :040000 040000 fe96635ddbb6bd32573fb831d76ec743455f4e53 40ffc05cda642a4c496d2c51023470e6ba8de467 M kernel --=20 You are receiving this mail because: You are the assignee for the bug.=