DPDK patches and discussions
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [Bug 1117] af-packet driver fix breaks rte_pktmbuf_prepend()
Date: Thu, 27 Oct 2022 19:00:33 +0000	[thread overview]
Message-ID: <bug-1117-3@http.bugs.dpdk.org/> (raw)

https://bugs.dpdk.org/show_bug.cgi?id=1117

            Bug ID: 1117
           Summary: af-packet driver fix breaks rte_pktmbuf_prepend()
           Product: DPDK
           Version: 21.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: bly454@gmail.com
  Target Milestone: ---

The following commit causes rte_pktmbuf_prepend() to fail when prepending the
full headroom reserved when creating the mbuf pool.

https://git.dpdk.org/dpdk-stable/commit/?h=21.11&id=d41d39bcf76900deb6aa000e929fd65734254201

Of issue is if the received frame was originally tagged (and vlan-stripped by
af-socket connection) the above commit does a vlan reinsert action as part of
eth_af_packet_rx(). This moves the SOF forward into the "reserved" space by
four bytes. For example, if the reserved space was 128 bytes and the next stage
of processing is a generic pipeline handling a variety of interface types, the
generic prepend of the reserved 128-byte meta-data space will fail. This means
you cannot use a common pipeline and have to have an exception now for
af-packet rx handling as compared to physical NIC, tap, vhost, etc. Ideally,
the initial SOF offset should be consistent relative to your design's reserved
headroom, regardless of the vlan tagged status of the frame or the interface
type it was received on.

-- 
You are receiving this mail because:
You are the assignee for the bug.

                 reply	other threads:[~2022-10-27 19:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-1117-3@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).