From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [Bug 1145] net/ice fdir flow create/destroy failed with RTE_LIBRTE_ICE_16BYTE_RX_DESC defined
Date: Fri, 09 Dec 2022 02:04:52 +0000 [thread overview]
Message-ID: <bug-1145-3@http.bugs.dpdk.org/> (raw)
https://bugs.dpdk.org/show_bug.cgi?id=1145
Bug ID: 1145
Summary: net/ice fdir flow create/destroy failed with
RTE_LIBRTE_ICE_16BYTE_RX_DESC defined
Product: DPDK
Version: 21.11
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: major
Priority: Normal
Component: ethdev
Assignee: dev@dpdk.org
Reporter: hanshuang87@gmail.com
Target Milestone: ---
Fdir rx queue use the same ice_rx_queue struct as packet rx queue.
When RTE_LIBRTE_ICE_16BYTE_RX_DESC defined rxq->rx_ring type is
ice_16b_rx_flex_desc.
#ifdef RTE_LIBRTE_ICE_16BYTE_RX_DESC
#define ice_rx_flex_desc ice_16b_rx_flex_desc
#else
#define ice_rx_flex_desc ice_32b_rx_flex_desc
#endif
But ice_check_fdir_programming_status check the rxdp assuming that rx_ring type
is ice_32byte_rx_desc.
rxdp = (volatile union ice_32byte_rx_desc *)(&rxq->rx_ring[rxq->rx_tail]);
I think this patch will fix the bug, but not the best solution：
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -4481,9 +4481,10 @@
uint32_t error;
uint32_t id;
int ret = -EAGAIN;
+ volatile union ice_32byte_rx_desc *rx_ring = rxq->rx_ring;
rxdp = (volatile union ice_32byte_rx_desc *)
- (&rxq->rx_ring[rxq->rx_tail]);
+ (&rx_ring[rxq->rx_tail]);
qword1 = rte_le_to_cpu_64(rxdp->wb.qword1.status_error_len);
rx_status = (qword1 & ICE_RXD_QW1_STATUS_M)
>> ICE_RXD_QW1_STATUS_S;
--
You are receiving this mail because:
You are the assignee for the bug.
reply other threads:[~2022-12-09 2:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-1145-3@http.bugs.dpdk.org/ \
--to=bugzilla@dpdk.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).