From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 5ADC9423AE;
Wed, 11 Jan 2023 15:22:45 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 1573840E25;
Wed, 11 Jan 2023 15:22:45 +0100 (CET)
Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178])
by mails.dpdk.org (Postfix) with ESMTP id C5FB340A7D
for <dev@dpdk.org>; Wed, 11 Jan 2023 15:22:43 +0100 (CET)
Received: by inbox.dpdk.org (Postfix, from userid 33)
id B25F6423AF; Wed, 11 Jan 2023 15:22:43 +0100 (CET)
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [Bug 1156] dpdk_flow_ops_fn api returns error for RSS queue action
Date: Wed, 11 Jan 2023 14:22:43 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: DPDK
X-Bugzilla-Component: other
X-Bugzilla-Version: 22.03
X-Bugzilla-Keywords:
X-Bugzilla-Severity: critical
X-Bugzilla-Who: lthammin@usc.edu
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: dev@dpdk.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
op_sys bug_status bug_severity priority component assigned_to reporter
target_milestone attachments.created
Message-ID: <bug-1156-3@http.bugs.dpdk.org/>
Content-Type: multipart/alternative; boundary=16734469630.0e34339.577686
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
MIME-Version: 1.0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
--16734469630.0e34339.577686
Date: Wed, 11 Jan 2023 15:22:43 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
https://bugs.dpdk.org/show_bug.cgi?id=3D1156
Bug ID: 1156
Summary: dpdk_flow_ops_fn api returns error for RSS queue
action
Product: DPDK
Version: 22.03
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: critical
Priority: Normal
Component: other
Assignee: dev@dpdk.org
Reporter: lthammin@usc.edu
Target Milestone: ---
Created attachment 238
--> https://bugs.dpdk.org/attachment.cgi?id=3D238&action=3Dedit
A temporary patch that solves the issue
Hi,
I would like to enable RSS on a set of queues of port through RTE flow.=20
For this I am calling dpdk_flow_ops_fn() by setting
vnet_flow_t flow;
flow.queue_index =3D start_queue_id;
flow.queue_num =3D end_queue_id - start_queue_id + 1;
flow.actions |=3D VNET_FLOW_ACTION_RSS;
But, dpdk_flow_ops_fn() returns VNET_FLOW_ERROR_NOT_SUPPORTED because it fa=
ils
the below condition:
switch (flow->type)
{
case VNET_FLOW_TYPE_ETHERNET:
case VNET_FLOW_TYPE_IP4:
case VNET_FLOW_TYPE_IP6:
case VNET_FLOW_TYPE_IP4_N_TUPLE:
case VNET_FLOW_TYPE_IP6_N_TUPLE:
case VNET_FLOW_TYPE_IP4_VXLAN:
case VNET_FLOW_TYPE_IP4_GTPC:
case VNET_FLOW_TYPE_IP4_GTPU:
case VNET_FLOW_TYPE_IP4_L2TPV3OIP:
case VNET_FLOW_TYPE_IP4_IPSEC_ESP:
case VNET_FLOW_TYPE_IP4_IPSEC_AH:
case VNET_FLOW_TYPE_GENERIC:
if ((rv =3D dpdk_flow_add (xd, flow, fe)))
goto done;
break;
default:
rv =3D VNET_FLOW_ERROR_NOT_SUPPORTED;
goto done;
}
It fails because flow->type is not one of above. The flow->type is set only=
if
a valid RTE flow pattern is required for the flow. For, RTE flows with RSS
Queue action, the pattern is not accepted. So, flow->type in this case shou=
ld
be invalid (VNET_FLOW_TYPE_UNKNOWN).
If we try to program a RTE flow with some pattern and RSS Queue action, we =
get
below error.
DBGvpp# sh flow int TenGigabitEthernetb5/0/3
supported flow actions : count mark buffer-advance redirect-to-node
redirect-to-queue rss drop
last DPDK error type : 15
last DPDK error message : RSS Queues not supported when pattern specified
DBGvpp#
dpdk_flow_ops_fn() calls dpdk_flow_add(). Note that, even if dpdk_flow_ops_=
fn()
is bypassed, dpdk_flow_add() still fails because of the below conditions.
if (FLOW_IS_ETHERNET_CLASS (f))
flow_class =3D FLOW_ETHERNET_CLASS;
else if (FLOW_IS_IPV4_CLASS (f))
flow_class =3D FLOW_IPV4_CLASS;
else if (FLOW_IS_IPV6_CLASS (f))
flow_class =3D FLOW_IPV6_CLASS;
else
return VNET_FLOW_ERROR_NOT_SUPPORTED;
I have attached a patch that I have been using temporarily. Please check it=
out
and provide an official patch.
Thanks,
Nikhil
--=20
You are receiving this mail because:
You are the assignee for the bug.=
--16734469630.0e34339.577686
Date: Wed, 11 Jan 2023 15:22:43 +0100
MIME-Version: 1.0
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
<html>
<head>
<base href=3D"https://bugs.dpdk.org/">
</head>
<body><table border=3D"1" cellspacing=3D"0" cellpadding=3D"8" class=3D"=
bz_new_table">
<tr>
<th>Bug ID</th>
<td><a class=3D"bz_bug_link=20
bz_status_UNCONFIRMED "
title=3D"UNCONFIRMED - dpdk_flow_ops_fn api returns error for RSS queue =
action"
href=3D"https://bugs.dpdk.org/show_bug.cgi?id=3D1156">1156</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>dpdk_flow_ops_fn api returns error for RSS queue action
</td>
</tr>
<tr>
<th>Product</th>
<td>DPDK
</td>
</tr>
<tr>
<th>Version</th>
<td>22.03
</td>
</tr>
<tr>
<th>Hardware</th>
<td>All
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>UNCONFIRMED
</td>
</tr>
<tr>
<th>Severity</th>
<td>critical
</td>
</tr>
<tr>
<th>Priority</th>
<td>Normal
</td>
</tr>
<tr>
<th>Component</th>
<td>other
</td>
</tr>
<tr>
<th>Assignee</th>
<td>dev@dpdk.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>lthammin@usc.edu
</td>
</tr>
<tr>
<th>Target Milestone</th>
<td>---
</td>
</tr></table>
<p>
<div class=3D"bz_comment_block">
<pre class=3D"bz_comment_text">Created <span class=3D""><a href=
=3D"attachment.cgi?id=3D238&action=3Ddiff" name=3D"attach_238" title=3D=
"A temporary patch that solves the issue">attachment 238</a> <a href=3D"att=
achment.cgi?id=3D238&action=3Dedit" title=3D"A temporary patch that sol=
ves the issue">[details]</a></span>
A temporary patch that solves the issue
Hi,
I would like to enable RSS on a set of queues of port through RTE flow.=20
For this I am calling dpdk_flow_ops_fn() by setting
vnet_flow_t flow;
flow.queue_index =3D start_queue_id;
flow.queue_num =3D end_queue_id - start_queue_id + 1;
flow.actions |=3D VNET_FLOW_ACTION_RSS;
But, dpdk_flow_ops_fn() returns VNET_FLOW_ERROR_NOT_SUPPORTED because it fa=
ils
the below condition:
switch (flow->type)
{
case VNET_FLOW_TYPE_ETHERNET:
case VNET_FLOW_TYPE_IP4:
case VNET_FLOW_TYPE_IP6:
case VNET_FLOW_TYPE_IP4_N_TUPLE:
case VNET_FLOW_TYPE_IP6_N_TUPLE:
case VNET_FLOW_TYPE_IP4_VXLAN:
case VNET_FLOW_TYPE_IP4_GTPC:
case VNET_FLOW_TYPE_IP4_GTPU:
case VNET_FLOW_TYPE_IP4_L2TPV3OIP:
case VNET_FLOW_TYPE_IP4_IPSEC_ESP:
case VNET_FLOW_TYPE_IP4_IPSEC_AH:
case VNET_FLOW_TYPE_GENERIC:
if ((rv =3D dpdk_flow_add (xd, flow, fe)))
goto done;
break;
default:
rv =3D VNET_FLOW_ERROR_NOT_SUPPORTED;
goto done;
}
It fails because flow->type is not one of above. The flow->type is se=
t only if
a valid RTE flow pattern is required for the flow. For, RTE flows with RSS
Queue action, the pattern is not accepted. So, flow->type in this case s=
hould
be invalid (VNET_FLOW_TYPE_UNKNOWN).
If we try to program a RTE flow with some pattern and RSS Queue action, we =
get
below error.
DBGvpp# sh flow int TenGigabitEthernetb5/0/3
supported flow actions : count mark buffer-advance redirect-to-node
redirect-to-queue rss drop
last DPDK error type : 15
last DPDK error message : RSS Queues not supported when pattern specified
DBGvpp#
dpdk_flow_ops_fn() calls dpdk_flow_add(). Note that, even if dpdk_flow_ops_=
fn()
is bypassed, dpdk_flow_add() still fails because of the below conditions.
if (FLOW_IS_ETHERNET_CLASS (f))
flow_class =3D FLOW_ETHERNET_CLASS;
else if (FLOW_IS_IPV4_CLASS (f))
flow_class =3D FLOW_IPV4_CLASS;
else if (FLOW_IS_IPV6_CLASS (f))
flow_class =3D FLOW_IPV6_CLASS;
else
return VNET_FLOW_ERROR_NOT_SUPPORTED;
I have attached a patch that I have been using temporarily. Please check it=
out
and provide an official patch.
Thanks,
Nikhil
</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
<div itemscope itemtype=3D"http://schema.org/EmailMessage">
<div itemprop=3D"action" itemscope itemtype=3D"http://schema.org/Vi=
ewAction">
=20=20=20=20=20=20=20=20=20=20
<link itemprop=3D"url" href=3D"https://bugs.dpdk.org/show_bug.cgi=
?id=3D1156">
<meta itemprop=3D"name" content=3D"View bug">
</div>
<meta itemprop=3D"description" content=3D"Bugzilla bug update notif=
ication">
</div>
</body>
</html>=
--16734469630.0e34339.577686--