From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bugzilla@dpdk.org>
Received: by dpdk.org (Postfix, from userid 33)
 id ADC431B1D6; Wed,  5 Dec 2018 06:27:29 +0100 (CET)
From: bugzilla@dpdk.org
To: dev@dpdk.org
Date: Wed, 05 Dec 2018 05:27:29 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: DPDK
X-Bugzilla-Component: core
X-Bugzilla-Version: 18.11
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vipin.varghese@intel.com
X-Bugzilla-Status: CONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: dev@dpdk.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 target_milestone
Message-ID: <bug-117-3@http.bugs.dpdk.org/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
MIME-Version: 1.0
Subject: [dpdk-dev] [Bug 117] in case of malloc_elem_alloc should we
 increment alloc_count (heap->alloc_count++)?
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Dec 2018 05:27:29 -0000

https://bugs.dpdk.org/show_bug.cgi?id=3D117

            Bug ID: 117
           Summary: in case of malloc_elem_alloc should we increment
                    alloc_count (heap->alloc_count++)?
           Product: DPDK
           Version: 18.11
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: normal
          Priority: Normal
         Component: core
          Assignee: dev@dpdk.org
          Reporter: vipin.varghese@intel.com
  Target Milestone: ---

file: lib/librte_eal/common/malloc_heap.c
function: heap_alloc

code snippet:

        elem =3D find_suitable_element(heap, size, flags, align, bound, con=
tig);
        if (elem !=3D NULL) {
                elem =3D malloc_elem_alloc(elem, size, align, bound, contig=
);

                /* increase heap's count of allocated elements */
                heap->alloc_count++;
        }

        return elem =3D=3D NULL ? NULL : (void *)(&elem[1]);


is this expected behavior to update counter even if it fails?

--=20
You are receiving this mail because:
You are the assignee for the bug.=