DPDK patches and discussions
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [Bug 1193] examples/vdpa closes port in non signal safe manner
Date: Mon, 20 Mar 2023 17:02:57 +0000	[thread overview]
Message-ID: <bug-1193-3@http.bugs.dpdk.org/> (raw)

[-- Attachment #1: Type: text/plain, Size: 1126 bytes --]

https://bugs.dpdk.org/show_bug.cgi?id=1193

            Bug ID: 1193
           Summary: examples/vdpa closes port in non signal safe manner
           Product: DPDK
           Version: unspecified
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: examples
          Assignee: dev@dpdk.org
          Reporter: stephen@networkplumber.org
  Target Milestone: ---

The vdpa sample application does:

signal(SIGINT, signal_handler);

Then signal_handler() doess
    vdpa_signal_quit() which calls close_vdpa()
    close_vdpa() calls rte_vhost_driver_detach_vdpa_device and unregister

These close and detach routines are not signal safe. It could cause a race
condition in vdpa driver if signal was received and processed by one thread
while another thread was in middle of interacting with host.

The correct way to handle this is to set a flag in the signal handler,
and exit the main processing loop; then cleanup.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #2: Type: text/html, Size: 3005 bytes --]

                 reply	other threads:[~2023-03-20 17:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-1193-3@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).