From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C87C6427E4; Mon, 20 Mar 2023 18:02:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5ED33410D0; Mon, 20 Mar 2023 18:02:59 +0100 (CET) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id C42C640A80 for ; Mon, 20 Mar 2023 18:02:57 +0100 (CET) Received: by inbox.dpdk.org (Postfix, from userid 33) id A3B4C427E5; Mon, 20 Mar 2023 18:02:57 +0100 (CET) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [Bug 1193] examples/vdpa closes port in non signal safe manner Date: Mon, 20 Mar 2023 17:02:57 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: examples X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: stephen@networkplumber.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: multipart/alternative; boundary=16793317770.f0E15Df.1330998 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --16793317770.f0E15Df.1330998 Date: Mon, 20 Mar 2023 18:02:57 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1193 Bug ID: 1193 Summary: examples/vdpa closes port in non signal safe manner Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component: examples Assignee: dev@dpdk.org Reporter: stephen@networkplumber.org Target Milestone: --- The vdpa sample application does: signal(SIGINT, signal_handler); Then signal_handler() doess vdpa_signal_quit() which calls close_vdpa() close_vdpa() calls rte_vhost_driver_detach_vdpa_device and unregister These close and detach routines are not signal safe. It could cause a race condition in vdpa driver if signal was received and processed by one thread while another thread was in middle of interacting with host. The correct way to handle this is to set a flag in the signal handler, and exit the main processing loop; then cleanup. --=20 You are receiving this mail because: You are the assignee for the bug.= --16793317770.f0E15Df.1330998 Date: Mon, 20 Mar 2023 18:02:57 +0100 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All

Bug ID	1193
Summary	examples/vdpa closes port in non signal safe manner
Product	DPDK
Version	unspecified
Hardware	All
OS	All
Status	UNCONFIRMED
Severity	normal
Priority	Normal
Component	examples
Assignee	dev@dpdk.org
Reporter	stephen@networkplumber.org
Target Milestone	---

The vdpa sample application does:

signal(SIGINT, signal_handler);

Then signal_handler() doess
    vdpa_signal_quit() which calls close_vdpa()
    close_vdpa() calls rte_vhost_driver_detach_vdpa_device and unregister

These close and detach routines are not signal safe. It could cause a race
condition in vdpa driver if signal was received and processed by one thread
while another thread was in middle of interacting with host.

The correct way to handle this is to set a flag in the signal handler,
and exit the main processing loop; then cleanup.

You are receiving this mail because:

You are the assignee for the bug.

=20=20=20=20=20=20=20=20=20=20

= --16793317770.f0E15Df.1330998--