From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B5B3427E4; Mon, 20 Mar 2023 18:08:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 081F3410EF; Mon, 20 Mar 2023 18:08:22 +0100 (CET) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id B159A40A80 for ; Mon, 20 Mar 2023 18:08:20 +0100 (CET) Received: by inbox.dpdk.org (Postfix, from userid 33) id A2368427E5; Mon, 20 Mar 2023 18:08:20 +0100 (CET) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [Bug 1194] l3fwd-cat: calling unsafe functions from signal handler Date: Mon, 20 Mar 2023 17:08:20 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: examples X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: stephen@networkplumber.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: multipart/alternative; boundary=16793321000.bBE1626d.1331767 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --16793321000.bBE1626d.1331767 Date: Mon, 20 Mar 2023 18:08:20 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1194 Bug ID: 1194 Summary: l3fwd-cat: calling unsafe functions from signal handler Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component: examples Assignee: dev@dpdk.org Reporter: stephen@networkplumber.org Target Milestone: --- The handling of SIGINT and SIGTERM in the l2fwd-cat example is unsafe and non-portable. The signal handler could be called by any thread at any time. The current method (copy/paste from testpmd?) is to call cat_exit() in the signal handler. This may race with other threads and cause problems. The better solution is to set a flag in signal handler and then do the shut= down aft er the main loop exits. --=20 You are receiving this mail because: You are the assignee for the bug.= --16793321000.bBE1626d.1331767 Date: Mon, 20 Mar 2023 18:08:20 +0100 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All

Bug ID	1194
Summary	l3fwd-cat: calling unsafe functions from signal handler
Product	DPDK
Version	unspecified
Hardware	All
OS	All
Status	UNCONFIRMED
Severity	normal
Priority	Normal
Component	examples
Assignee	dev@dpdk.org
Reporter	stephen@networkplumber.org
Target Milestone	---

The handling of SIGINT and SIGTERM=
 in the l2fwd-cat example is unsafe and
non-portable.  The signal handler could be called by any thread at any time.

The current method (copy/paste from testpmd?) is to call cat_exit() in the
signal handler. This may race with other threads and cause problems.

The better solution is to set a flag in signal handler and then do the shut=
down
aft er the main loop exits.

You are receiving this mail because:

You are the assignee for the bug.

=20=20=20=20=20=20=20=20=20=20

= --16793321000.bBE1626d.1331767--