From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B529B43D8A; Sat, 30 Mar 2024 03:58:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45DF4402C6; Sat, 30 Mar 2024 03:58:44 +0100 (CET) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id 96856402C3 for ; Sat, 30 Mar 2024 03:58:42 +0100 (CET) Received: by inbox.dpdk.org (Postfix, from userid 33) id 7466B43D8B; Sat, 30 Mar 2024 03:58:42 +0100 (CET) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [DPDK/core Bug 1409] arparse library assumes enum are 64 bit Date: Sat, 30 Mar 2024 02:58:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: core X-Bugzilla-Version: 24.03 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: stephen@networkplumber.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: multipart/alternative; boundary=17117675220.Feeb0a5.247008 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --17117675220.Feeb0a5.247008 Date: Sat, 30 Mar 2024 03:58:42 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1409 Bug ID: 1409 Summary: arparse library assumes enum are 64 bit Product: DPDK Version: 24.03 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component: core Assignee: dev@dpdk.org Reporter: stephen@networkplumber.org Target Milestone: --- MSVC correctly flags that this line in rte_argparse.h is incorrect: RTE_ARGPARSE_ARG_RESERVED_FIELD =3D RTE_GENMASK64(63, 48), The problem is that enum values are just an alias for int, and it can be 32 bits. Taken from the current C Standard (C99): http://www.open std.org/JTC1/SC22/WG14/www/docs/n1256.pdf 6.7.2.2 Enumeration specifiers [...] Constraints The expression that defines the value of an enumeration constant shall be an integer constant expression that has a value representable as an int. [...] Each enumerated type shall be compatible with char, a signed integer type, = or an unsigned integer type. The choice of type is implementation-defined, but shall be capable of representing the values of all the members of the enumeration. Since rte_argparse only uses 10 bits now. The suggested fix here is to: 1. Assume 32 bits 2. Get rid of the reserved field - reserved fields are bad idea --=20 You are receiving this mail because: You are the assignee for the bug.= --17117675220.Feeb0a5.247008 Date: Sat, 30 Mar 2024 03:58:42 +0100 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All
Bug ID 1409
Summary arparse library assumes enum are 64 bit
Product DPDK
Version 24.03
Hardware All
OS All
Status UNCONFIRMED
Severity normal
Priority Normal
Component core
Assignee dev@dpdk.org
Reporter stephen@networkplumber.org
Target Milestone --- 

MSVC correctly flags that this lin=
e in rte_argparse.h is incorrect:
        RTE_ARGPARSE_ARG_RESERVED_FIELD =3D RTE_GENMASK64(63, 48),

The problem is that enum values are just an alias for int, and it can be 32
bits.

Taken from the current C Standard (C99):
 http://www.open std.org/JTC1/SC22/WG14/www=
/docs/n1256.pdf

6.7.2.2 Enumeration specifiers
[...]
Constraints
The expression that defines the value of an enumeration constant shall be an
integer constant expression that has a value representable as an int.
[...]
Each enumerated type shall be compatible with char, a signed integer type, =
or
an unsigned integer type. The choice of type is implementation-defined, but
shall be capable of representing the values of all the members of the
enumeration.

Since rte_argparse only uses 10 bits now. The suggested fix here is to:
   1. Assume 32 bits
   2. Get rid of the reserved field - reserved fields are bad idea

You are receiving this mail because:
  • You are the assignee for the bug.
=20=20=20=20=20=20=20=20=20=20
= --17117675220.Feeb0a5.247008--