DPDK patches and discussions
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [DPDK/ethdev Bug 1416] net/af_packet: tx_burst() can modify packets
Date: Tue, 16 Apr 2024 15:58:33 +0000	[thread overview]
Message-ID: <bug-1416-3-mIDybtgJXl@http.bugs.dpdk.org/> (raw)
In-Reply-To: <bug-1416-3@http.bugs.dpdk.org/>

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

https://bugs.dpdk.org/show_bug.cgi?id=1416

Konstantin Ananyev (konstantin.v.ananyev@yandex.ru) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Konstantin Ananyev (konstantin.v.ananyev@yandex.ru) ---
As Stephen Hemminger <stephen@networkplumber.org> pointed out:

vlan_insert will fail if the mbuf is has refcnt > 1.

static inline int rte_vlan_insert(struct rte_mbuf **m)
{
        struct rte_ether_hdr *oh, *nh;
        struct rte_vlan_hdr *vh;

        /* Can't insert header if mbuf is shared */
        if (!RTE_MBUF_DIRECT(*m) || rte_mbuf_refcnt_read(*m) > 1)
                return -EINVAL;

So closing as not a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #2: Type: text/html, Size: 3050 bytes --]

      parent reply	other threads:[~2024-04-16 15:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-16 10:29 bugzilla
2024-04-16 15:38 ` Stephen Hemminger
2024-04-16 15:56   ` Konstantin Ananyev
2024-04-16 16:14     ` Morten Brørup
2024-04-16 16:42       ` Konstantin Ananyev
2024-04-16 18:11         ` Morten Brørup
2024-04-16 20:09           ` Stephen Hemminger
2024-04-16 22:21             ` Morten Brørup
2024-04-16 15:58 ` bugzilla [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-1416-3-mIDybtgJXl@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).