From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56B8843E83; Tue, 16 Apr 2024 17:58:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1BE8A40268; Tue, 16 Apr 2024 17:58:35 +0200 (CEST) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id 8AA2540262 for ; Tue, 16 Apr 2024 17:58:33 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id 7AB9743E86; Tue, 16 Apr 2024 17:58:33 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [DPDK/ethdev Bug 1416] net/af_packet: tx_burst() can modify packets Date: Tue, 16 Apr 2024 15:58:33 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: ethdev X-Bugzilla-Version: 24.03 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: konstantin.v.ananyev@yandex.ru X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: INVALID X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status resolution Message-ID: In-Reply-To: References: Content-Type: multipart/alternative; boundary=17132831130.48eEAc.1016307 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --17132831130.48eEAc.1016307 Date: Tue, 16 Apr 2024 17:58:33 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1416 Konstantin Ananyev (konstantin.v.ananyev@yandex.ru) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID --- Comment #1 from Konstantin Ananyev (konstantin.v.ananyev@yandex.ru) --- As Stephen Hemminger pointed out: vlan_insert will fail if the mbuf is has refcnt > 1. static inline int rte_vlan_insert(struct rte_mbuf **m) { struct rte_ether_hdr *oh, *nh; struct rte_vlan_hdr *vh; /* Can't insert header if mbuf is shared */ if (!RTE_MBUF_DIRECT(*m) || rte_mbuf_refcnt_read(*m) > 1) return -EINVAL; So closing as not a bug. --=20 You are receiving this mail because: You are the assignee for the bug.= --17132831130.48eEAc.1016307 Date: Tue, 16 Apr 2024 17:58:33 +0200 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All Konstantin Ananyev changed bug 1416

What	Removed	Added
Status	UNCONFIRMED	RESOLVED
Resolution	---	INVALID

Comment # 1 on bug 1416 from Konstantin Ananyev

As Stephen Hemminger <stephen@networkplumber.org> pointed out:

vlan_insert will fail if the mbuf is has refcnt > 1.

static inline int rte_vlan_insert(struct rte_mbuf **m)
{
        struct rte_ether_hdr *oh, *nh;
        struct rte_vlan_hdr *vh;

        /* Can't insert header if mbuf is shared */
        if (!RTE_MBUF_DIRECT(*m) || rte_mbuf_refcnt_read(*m) > 1)
                return -EINVAL;

So closing as not a bug.

You are receiving this mail because:

You are the assignee for the bug.

=20=20=20=20=20=20=20=20=20=20

= --17132831130.48eEAc.1016307--