From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E878943EE9; Tue, 23 Apr 2024 13:08:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D375F40E54; Tue, 23 Apr 2024 13:08:24 +0200 (CEST) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id 3F01C402AB for ; Tue, 23 Apr 2024 13:08:23 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id 306CD43EEA; Tue, 23 Apr 2024 13:08:23 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [DPDK/other Bug 1418] ice: no way to disable lsc-interrupts Date: Tue, 23 Apr 2024 11:08:22 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: other X-Bugzilla-Version: 24.03 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: robin@jarry.cc X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc target_milestone Message-ID: Content-Type: multipart/alternative; boundary=17138705030.CfCda9fD.1139675 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --17138705030.CfCda9fD.1139675 Date: Tue, 23 Apr 2024 13:08:22 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1418 Bug ID: 1418 Summary: ice: no way to disable lsc-interrupts Product: DPDK Version: 24.03 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: Normal Component: other Assignee: dev@dpdk.org Reporter: robin@jarry.cc CC: ktraynor@redhat.com Target Milestone: --- Hi all, Apparently, the ice driver does not allow disabling lsc interrupts. Starting testpmd with --no-lsc-interrupt gives this in the console: testpmd> ice_interrupt_handler(): OICR: link state change event Port 0: link state change event ice_interrupt_handler(): OICR: link state change event Port 1: link state change event I tested with version 22.11 which seems not to have the issue. I found a suspicious commit introduced in 24.03 which may be the culprit: commit 4e5dc111464e83e9a55fa466d8f682f0027b721e Author: Qi Zhang Date: Thu Dec 14 03:40:54 2023 -0500 net/ice: fix link update The ice_aq_get_link_info function is not thread-safe. However, it is possible to simultaneous invocations during both the dev_start and the LSC interrupt handler, potentially leading to unexpected adminq errors. This patch addresses the issue by introducing a thread-safe wrapper that utilizes a spinlock. Fixes: cf911d90e366 ("net/ice: support link update") Cc: stable@dpdk.org Signed-off-by: Qi Zhang Acked-by: Qiming Yang https://git.dpdk.org/dpdk/commit/?id=3D4e5dc111464e83e9a55fa466d8f682f0027b= 721e --=20 You are receiving this mail because: You are the assignee for the bug.= --17138705030.CfCda9fD.1139675 Date: Tue, 23 Apr 2024 13:08:23 +0200 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All
Bug ID 1418
Summary ice: no way to disable lsc-interrupts
Product DPDK
Version 24.03
Hardware x86
OS Linux
Status UNCONFIRMED
Severity normal
Priority Normal
Component other
Assignee dev@dpdk.org
Reporter robin@jarry.cc
CC ktraynor@redhat.com
Target Milestone --- 

Hi all,

Apparently, the ice driver does not allow disabling lsc interrupts. Starting
testpmd with --no-lsc-interrupt gives this in the console:

testpmd> ice_interrupt_handler(): OICR: link state change event
Port 0: link state change event
ice_interrupt_handler(): OICR: link state change event
Port 1: link state change event

I tested with version 22.11 which seems not to have the issue. I found a
suspicious commit introduced in 24.03 which may be the culprit:

commit 4e5dc111464e83e9a55fa466d8f682f0027b721e
Author: Qi Zhang <qi.z.zhang=
@intel.com>
Date:   Thu Dec 14 03:40:54 2023 -0500

    net/ice: fix link update

    The ice_aq_get_link_info function is not thread-safe. However,
    it is possible to simultaneous invocations during both the dev_start
    and the LSC interrupt handler, potentially leading to unexpected adminq
    errors. This patch addresses the issue by introducing a thread-safe
    wrapper that utilizes a spinlock.

    Fixes: cf911d90e366 ("net/ice: support link update")
    Cc: stable@dpdk.org

    Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
    Acked-by: Qiming Yang <=
qiming.yang@intel.com>

https://git.dpdk.org/dpdk/commit/?id=3D4e5dc111464e83e9a55=
fa466d8f682f0027b721e

You are receiving this mail because:
  • You are the assignee for the bug.
=20=20=20=20=20=20=20=20=20=20
= --17138705030.CfCda9fD.1139675--