From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5145A4410E; Thu, 30 May 2024 10:44:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 23644402F1; Thu, 30 May 2024 10:44:59 +0200 (CEST) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id A301D40041 for ; Thu, 30 May 2024 10:44:57 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id 8C44E4410F; Thu, 30 May 2024 10:44:57 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [DPDK/ethdev Bug 1448] cannot disable RTE_ETHDEV_RXTX_CALLBACKS from rte_config.h Date: Thu, 30 May 2024 08:44:56 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: ethdev X-Bugzilla-Version: 24.07 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: gakhil@marvell.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: multipart/alternative; boundary=17170586970.bE22745f.3111476 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --17170586970.bE22745f.3111476 Date: Thu, 30 May 2024 10:44:57 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1448 Bug ID: 1448 Summary: cannot disable RTE_ETHDEV_RXTX_CALLBACKS from rte_config.h Product: DPDK Version: 24.07 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component: ethdev Assignee: dev@dpdk.org Reporter: gakhil@marvell.com Target Milestone: --- RTE_ETHDEV_RXTX_CALLBACKS is used with ifdefs in ethdev. But it is defined = as #define RTE_ETHDEV_RXTX_CALLBACKS 1 in rte_config.h Hence we cannot actually disable it unless we undef/comment it. Rather, we should use #if --=20 You are receiving this mail because: You are the assignee for the bug.= --17170586970.bE22745f.3111476 Date: Thu, 30 May 2024 10:44:57 +0200 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All

Bug ID	1448
Summary	cannot disable RTE_ETHDEV_RXTX_CALLBACKS from rte_config.h
Product	DPDK
Version	24.07
Hardware	All
OS	All
Status	UNCONFIRMED
Severity	normal
Priority	Normal
Component	ethdev
Assignee	dev@dpdk.org
Reporter	gakhil@marvell.com
Target Milestone	---

RTE_ETHDEV_RXTX_CALLBACKS is used =
with ifdefs in ethdev. But it is defined as
#define RTE_ETHDEV_RXTX_CALLBACKS 1
in rte_config.h

Hence we cannot actually disable it unless we undef/comment it.
Rather, we should use #if

You are receiving this mail because:

You are the assignee for the bug.

=20=20=20=20=20=20=20=20=20=20

= --17170586970.bE22745f.3111476-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E64A64410E; Thu, 30 May 2024 12:54:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F4E540685; Thu, 30 May 2024 12:54:41 +0200 (CEST) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id E6DC940608 for ; Thu, 30 May 2024 12:54:39 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id C107A44111; Thu, 30 May 2024 12:54:39 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [DPDK/ethdev Bug 1448] cannot disable RTE_ETHDEV_RXTX_CALLBACKS from rte_config.h Date: Thu, 30 May 2024 10:54:39 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: ethdev X-Bugzilla-Version: 24.07 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mb@smartsharesystems.com X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: INVALID X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc bug_status resolution Message-ID: In-Reply-To: References: Content-Type: multipart/alternative; boundary=17170664791.6b8F4.3151741 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --17170664791.6b8F4.3151741 Date: Thu, 30 May 2024 12:54:39 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1448 Morten Br=C3=B8rup (mb@smartsharesystems.com) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mb@smartsharesystems.com Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID --- Comment #1 from Morten Br=C3=B8rup (mb@smartsharesystems.com) --- Using #ifdef is the convention in DPDK, like in the Linux Kernel. The way to disable it is to outcomment it like this: /* RTE_ETHDEV_RXTX_CALLBACKS is not set */ E.g.: https://elixir.bootlin.com/dpdk/v24.03/source/config/rte_config.h#L60 --=20 You are receiving this mail because: You are the assignee for the bug.= --17170664791.6b8F4.3151741 Date: Thu, 30 May 2024 12:54:39 +0200 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All Morten Br=C3=B8rup changed bug 1448

What	Removed	Added
CC		mb@smartsharesystems.com
Status	UNCONFIRMED	RESOLVED
Resolution	---	INVALID

Comment # 1 on bug 1448 from Morten Br=C3=B8rup

Using #ifdef is the convention in =
DPDK, like in the Linux Kernel.

The way to disable it is to outcomment it like this:

/* RTE_ETHDEV_RXTX_CALLBACKS is not set */

E.g.:
https://elixir.bootlin.com/dpdk/v24.03/source/config/rte_config.h#L6=
0

You are receiving this mail because:

You are the assignee for the bug.

=20=20=20=20=20=20=20=20=20=20

= --17170664791.6b8F4.3151741-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73A9844111; Thu, 30 May 2024 16:05:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 540D140ED0; Thu, 30 May 2024 16:05:05 +0200 (CEST) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id 250E540ED0 for ; Thu, 30 May 2024 16:05:04 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id 0986A44113; Thu, 30 May 2024 16:05:04 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [DPDK/ethdev Bug 1448] cannot disable RTE_ETHDEV_RXTX_CALLBACKS from rte_config.h Date: Thu, 30 May 2024 14:05:04 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: ethdev X-Bugzilla-Version: 24.07 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: thomas@monjalon.net X-Bugzilla-Status: CONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status resolution cc everconfirmed Message-ID: In-Reply-To: References: Content-Type: multipart/alternative; boundary=17170779031.B0f32dE.3203457 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --17170779031.B0f32dE.3203457 Date: Thu, 30 May 2024 16:05:03 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1448 Thomas Monjalon (thomas@monjalon.net) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CONFIRMED Resolution|INVALID |--- CC| |thomas@monjalon.net Ever confirmed|0 |1 --- Comment #2 from Thomas Monjalon (thomas@monjalon.net) --- We are not supposed to change anything in config/rte_config.h because it is a source file. The configuration should be changed only in the application or with Meson. If think using #if is the good option here. --=20 You are receiving this mail because: You are the assignee for the bug.= --17170779031.B0f32dE.3203457 Date: Thu, 30 May 2024 16:05:03 +0200 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All Thomas Monjalon changed bug 1448

What	Removed	Added
Status	RESOLVED	CONFIRMED
Resolution	INVALID	---
CC		thomas@monjalon.net
Ever confirmed		1

Comment # 2 on bug 1448 from Thomas Monjalon

We are not supposed to change anyt=
hing in config/rte_config.h
because it is a source file.
The configuration should be changed only in the application or with Meson.

If think using #if is the good option here.

You are receiving this mail because:

You are the assignee for the bug.

=20=20=20=20=20=20=20=20=20=20

= --17170779031.B0f32dE.3203457-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D97EC44111; Thu, 30 May 2024 16:28:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 839C540DC9; Thu, 30 May 2024 16:28:49 +0200 (CEST) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id D393840A7F for ; Thu, 30 May 2024 16:28:48 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id BB6BE44113; Thu, 30 May 2024 16:28:48 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [DPDK/ethdev Bug 1448] cannot disable RTE_ETHDEV_RXTX_CALLBACKS from rte_config.h Date: Thu, 30 May 2024 14:28:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: ethdev X-Bugzilla-Version: 24.07 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mb@smartsharesystems.com X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: INVALID X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: multipart/alternative; boundary=17170793281.bC0fAFCb.3209117 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --17170793281.bC0fAFCb.3209117 Date: Thu, 30 May 2024 16:28:48 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1448 Morten Br=C3=B8rup (mb@smartsharesystems.com) changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|CONFIRMED |RESOLVED --- Comment #3 from Morten Br=C3=B8rup (mb@smartsharesystems.com) --- The config/rte_config.h source code configuration is for exotic configurati= on parameters that we don't want to expose to Meson. The threshold between normal and exotic is not well defined. :-) The bug report says that ethdev rx/tx callbacks cannot be disabled in config/rte_config.h, where it is configurable. This is not correct. They ca= n be disabled in config/rte_config.h, so there is no bug; the bug reporter just didn't know how to do it. Although I personally prefer #if over #ifdef, it would be a huge patch seri= es to replace all occurrences of #ifdef XYZ with #if XYZ. (2800+ LOC containing '#ifdef': grep -r '#ifdef' | grep -v '__cplusplus' | wc) --=20 You are receiving this mail because: You are the assignee for the bug.= --17170793281.bC0fAFCb.3209117 Date: Thu, 30 May 2024 16:28:48 +0200 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All Morten Br=C3=B8rup changed bug 1448

What	Removed	Added
Resolution	---	INVALID
Status	CONFIRMED	RESOLVED

Comment # 3 on bug 1448 from Morten Br=C3=B8rup

The config/rte_config.h source cod=
e configuration is for exotic configuration
parameters that we don't want to expose to Meson.

The threshold between normal and exotic is not well defined. :-)

The bug report says that ethdev rx/tx callbacks cannot be disabled in
config/rte_config.h, where it is configurable. This is not correct. They ca=
n be
disabled in config/rte_config.h, so there is no bug; the bug reporter just
didn't know how to do it.

Although I personally prefer #if over #ifdef, it would be a huge patch seri=
es
to replace all occurrences of #ifdef XYZ with #if XYZ. (2800+ LOC containing
'#ifdef': grep -r '#ifdef' | grep -v '__cplusplus' | wc)

You are receiving this mail because:

You are the assignee for the bug.

=20=20=20=20=20=20=20=20=20=20

= --17170793281.bC0fAFCb.3209117--