From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 59CBE45496;
	Tue, 18 Jun 2024 21:56:25 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 32799402CB;
	Tue, 18 Jun 2024 21:56:25 +0200 (CEST)
Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178])
 by mails.dpdk.org (Postfix) with ESMTP id 8FD164027C
 for <dev@dpdk.org>; Tue, 18 Jun 2024 21:56:23 +0200 (CEST)
Received: by inbox.dpdk.org (Postfix, from userid 33)
 id 7B65745497; Tue, 18 Jun 2024 21:56:23 +0200 (CEST)
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [DPDK/ethdev Bug 1464] VLAN filtering bug
Date: Tue, 18 Jun 2024 19:56:23 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: DPDK
X-Bugzilla-Component: ethdev
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dmarx@iol.unh.edu
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: dev@dpdk.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 target_milestone
Message-ID: <bug-1464-3@http.bugs.dpdk.org/>
Content-Type: multipart/alternative; boundary=17187405830.58dE.2486990
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
MIME-Version: 1.0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org


--17187405830.58dE.2486990
Date: Tue, 18 Jun 2024 21:56:23 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All

https://bugs.dpdk.org/show_bug.cgi?id=3D1464

            Bug ID: 1464
           Summary: VLAN filtering bug
           Product: DPDK
           Version: unspecified
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: dmarx@iol.unh.edu
  Target Milestone: ---

Hi all,=20

I've written a test suite for VLAN features on DPDK drivers including
filtering, stripping, and insertion, but I've run into some issues=20
with Intel and Broadcom NICs. Both are forwarding packets when there are vl=
an
filter rules in place which should block packet forwarding.=20
To recreate the environment I'm running the tests on:=20

drivers: bnxt_en, i40e=20

Broadcom NIC info:=20

~$ ethtool -i ens2f0np0=20
driver: bnxt_en=20
version: 5.15.0-112-generic=20
firmware-version: 229.0.141.0/pkg 229.1.123.0=20
expansion-rom-version:=20=20
bus-info: 0000:61:00.0=20
supports-statistics: yes=20
supports-test: yes=20
supports-eeprom-access: yes=20
supports-register-dump: yes=20
supports-priv-flags: no=20

./dpdk-testpmd <EAL params> -- -i --portmask=3D0x3=20
testpmd> set fwd mac=20
testpmd> set promisc 0 off=20
testpmd> vlan set filter on 0=20
testpmd> rx_vlan add 1 0=20
testpmd> start=20

then, I build the following packet and send it to port 0 on testpmd:=20
packet =3D Ether()/Dot1Q(vlan=3D2)/Raw(load=3D'xxxxx')=20

The Mellanox CX-5s show the expected behavior, where a packet with a VLAN t=
ag
not in the filter list is dropped. However, with the Intel XL710=20
and Broadcom 57414 NICs, the packet is forwarded regardless of whether its =
VLAN
tag is in the filter list or not.=20
Link to the suite:
https://patches.dpdk.org/project/dpdk/patch/20240618162939.23339-2-dmarx@io=
l.unh.edu/=20
Series cover letter:
https://patches.dpdk.org/project/dpdk/cover/20240614150238.26374-1-dmarx@io=
l.unh.edu/=20
Any insight is appreciated.

--=20
You are receiving this mail because:
You are the assignee for the bug.=

--17187405830.58dE.2486990
Date: Tue, 18 Jun 2024 21:56:23 +0200
MIME-Version: 1.0
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All

<html>
    <head>
      <base href=3D"https://bugs.dpdk.org/">
    </head>
    <body><table border=3D"1" cellspacing=3D"0" cellpadding=3D"8" class=3D"=
bz_new_table">
        <tr>
          <th>Bug ID</th>
          <td><a class=3D"bz_bug_link=20
          bz_status_UNCONFIRMED "
   title=3D"UNCONFIRMED - VLAN filtering bug"
   href=3D"https://bugs.dpdk.org/show_bug.cgi?id=3D1464">1464</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>VLAN filtering bug
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>DPDK
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>unspecified
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>All
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>All
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>UNCONFIRMED
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>Normal
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>ethdev
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>dev&#64;dpdk.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>dmarx&#64;iol.unh.edu
          </td>
        </tr>

        <tr>
          <th>Target Milestone</th>
          <td>---
          </td>
        </tr></table>
      <p>
        <div class=3D"bz_comment_block">
          <pre class=3D"bz_comment_text">Hi all,=20

I've written a test suite for VLAN features on DPDK drivers including
filtering, stripping, and insertion, but I've run into some issues=20
with Intel and Broadcom NICs. Both are forwarding packets when there are vl=
an
filter rules in place which should block packet forwarding.=20
To recreate the environment I'm running the tests on:=20

drivers: bnxt_en, i40e=20

Broadcom NIC info:=20

~$ ethtool -i ens2f0np0=20
driver: bnxt_en=20
version: 5.15.0-112-generic=20
firmware-version: 229.0.141.0/pkg 229.1.123.0=20
expansion-rom-version:=20=20
bus-info: 0000:61:00.0=20
supports-statistics: yes=20
supports-test: yes=20
supports-eeprom-access: yes=20
supports-register-dump: yes=20
supports-priv-flags: no=20

./dpdk-testpmd &lt;EAL params&gt; -- -i --portmask=3D0x3=20
testpmd&gt; set fwd mac=20
testpmd&gt; set promisc 0 off=20
testpmd&gt; vlan set filter on 0=20
testpmd&gt; rx_vlan add 1 0=20
testpmd&gt; start=20

then, I build the following packet and send it to port 0 on testpmd:=20
packet =3D Ether()/Dot1Q(vlan=3D2)/Raw(load=3D'xxxxx')=20

The Mellanox CX-5s show the expected behavior, where a packet with a VLAN t=
ag
not in the filter list is dropped. However, with the Intel XL710=20
and Broadcom 57414 NICs, the packet is forwarded regardless of whether its =
VLAN
tag is in the filter list or not.=20
Link to the suite:
<a href=3D"https://patches.dpdk.org/project/dpdk/patch/20240618162939.23339=
-2-dmarx&#64;iol.unh.edu/">https://patches.dpdk.org/project/dpdk/patch/2024=
0618162939.23339-2-dmarx&#64;iol.unh.edu/</a>=20
Series cover letter:
<a href=3D"https://patches.dpdk.org/project/dpdk/cover/20240614150238.26374=
-1-dmarx&#64;iol.unh.edu/">https://patches.dpdk.org/project/dpdk/cover/2024=
0614150238.26374-1-dmarx&#64;iol.unh.edu/</a>=20
Any insight is appreciated.
          </pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
      <div itemscope itemtype=3D"http://schema.org/EmailMessage">
        <div itemprop=3D"action" itemscope itemtype=3D"http://schema.org/Vi=
ewAction">
=20=20=20=20=20=20=20=20=20=20
          <link itemprop=3D"url" href=3D"https://bugs.dpdk.org/show_bug.cgi=
?id=3D1464">
          <meta itemprop=3D"name" content=3D"View bug">
        </div>
        <meta itemprop=3D"description" content=3D"Bugzilla bug update notif=
ication">
      </div>
    </body>
</html>=

--17187405830.58dE.2486990--