https://bugs.dpdk.org/show_bug.cgi?id=1741

            Bug ID: 1741
           Summary: net/intel: duplicate identical branches
           Product: DPDK
           Version: unspecified
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: stephen@networkplumber.org
  Target Milestone: ---

Enabling warning for duplicate branches finds several bits of suspect code:

[556/3631] Compiling C object
drivers/libtmp_rte_net_i40e.a.p/net_intel_i40e_i40e_tm.c.o
In file included from ../drivers/net/intel/i40e/i40e_tm.c:8:
../drivers/net/intel/i40e/i40e_ethdev.h: In function ‘i40e_calc_itr_interval’:
../drivers/net/intel/i40e/i40e_ethdev.h:1514:20: warning: this condition has
identical branches [-Wduplicated-branches]
 1514 |                 if (is_pf)
      |                    ^
[557/3631] Compiling C object
drivers/libtmp_rte_net_i40e.a.p/net_intel_i40e_base_i40e_diag.c.o
[558/3631] Compiling C object
drivers/libtmp_rte_net_i40e.a.p/net_intel_i40e_i40e_vf_representor.c.o
In file included from ../drivers/net/intel/i40e/i40e_vf_representor.c:13:
../drivers/net/intel/i40e/i40e_ethdev.h: In function ‘i40e_calc_itr_interval’:
../drivers/net/intel/i40e/i40e_ethdev.h:1514:20: warning: this condition has
identical branches [-Wduplicated-branches]
 1514 |                 if (is_pf)
      |                    ^
[559/3631] Compiling C object
drivers/libtmp_rte_net_i40e.a.p/net_intel_i40e_i40e_recycle_mbufs_vec_common.c.o
In file included from
../drivers/net/intel/i40e/i40e_recycle_mbufs_vec_common.c:10:
../drivers/net/intel/i40e/i40e_ethdev.h: In function ‘i40e_calc_itr_interval’:
../drivers/net/intel/i40e/i40e_ethdev.h:1514:20: warning: this condition has
identical branches [-Wduplicated-branches]
 1514 |                 if (is_pf)
      |    

[558/3631] Compiling C object
drivers/libtmp_rte_net_i40e.a.p/net_intel_i40e_i40e_vf_representor.c.o
In file included from ../drivers/net/intel/i40e/i40e_vf_representor.c:13:
../drivers/net/intel/i40e/i40e_ethdev.h: In function ‘i40e_calc_itr_interval’:
../drivers/net/intel/i40e/i40e_ethdev.h:1514:20: warning: this condition has
identical branches [-Wduplicated-branches]
 1514 |                 if (is_pf)
      |                    ^
[559/3631] Compiling C object
drivers/libtmp_rte_net_i40e.a.p/net_intel_i40e_i40e_recycle_mbufs_vec_common.c.o
In file included from
../drivers/net/intel/i40e/i40e_recycle_mbufs_vec_common.c:10:
../drivers/net/intel/i40e/i40e_ethdev.h: In function ‘i40e_calc_itr_interval’:
../drivers/net/intel/i40e/i40e_ethdev.h:1514:20: warning: this condition has
identical branches [-Wduplicated-branches]
 1514 |                 if (is_pf)
      |                    ^
[560/3631] Compiling C object
drivers/libtmp_rte_net_dpaa2.a.p/net_dpaa2_dpaa2_ethdev.c.o
[561/3631] Compiling C object
drivers/libtmp_rte_net_iavf.a.p/net_intel_iavf_iavf_base_symbols.c.o
[562/3631] Compiling C object
drivers/libtmp_rte_net_i40e.a.p/net_intel_i40e_base_i40e_dcb.c.o
[563/3631] Compiling C object
drivers/libtmp_rte_net_i40e.a.p/net_intel_i40e_i40e_hash.c.o
In file included from ../drivers/net/intel/i40e/i40e_hash.c:16:
../drivers/net/intel/i40e/i40e_ethdev.h: In function ‘i40e_calc_itr_interval’:
../drivers/net/intel/i40e/i40e_ethdev.h:1514:20: warning: this condition has
identical branches [-Wduplicated-branches]
 1514 |                 if (is_pf)
      |                    ^
[564/3631] Compiling C object
drivers/libtmp_rte_net_i40e.a.p/net_intel_i40e_i40e_pf.c.o
In file included from ../drivers/net/intel/i40e/i40e_pf.c:25:
../drivers/net/intel/i40e/i40e_ethdev.h: In function ‘i40e_calc_itr_interval’:
../drivers/net/intel/i40e/i40e_ethdev.h:1514:20: warning: this condition has
identical branches [-Wduplicated-branches]
 1514 |                 if (is_pf)
      |                    ^
[565/3631] Compiling C object
drivers/libtmp_rte_net_i40e.a.p/net_intel_i40e_base_i40e_hmc.c.o
[566/3631] Compiling C object
drivers/libtmp_rte_net_i40e.a.p/net_intel_i40e_i40e_fdir.c.o
In file included from ../drivers/net/intel/i40e/i40e_fdir.c:30:
../drivers/net/intel/i40e/i40e_ethdev.h: In function ‘i40e_calc_itr_interval’:
../drivers/net/intel/i40e/i40e_ethdev.h:1514:20: warning: this condition has
identical branches [-Wduplicated-branches]
 1514 |                 if (is_pf)
      |                    ^
[567/3631] Compiling C object
drivers/libtmp_rte_net_i40e.a.p/net_intel_i40e_base_i40e_adminq.c.o
[568/3631] Compiling C object
drivers/libtmp_rte_net_i40e.a.p/net_intel_i40e_base_i40e_lan_hmc.c.o
[569/3631] Compiling C object
drivers/libtmp_rte_net_iavf.a.p/net_intel_iavf_base_iavf_impl.c.o
[570/3631] Compiling C object
drivers/libtmp_rte_net_iavf.a.p/net_intel_iavf_base_iavf_common.c.o
[571/3631] Compiling C object
drivers/libtmp_rte_net_i40e.a.p/net_intel_i40e_i40e_flow.c.o
In file included from ../drivers/net/intel/i40e/i40e_flow.c:25:
../drivers/net/intel/i40e/i40e_ethdev.h: In function ‘i40e_calc_itr_interval’:
../drivers/net/intel/i40e/i40e_ethdev.h:1514:20: warning: this condition has
identical branches [-Wduplicated-branches]
 1514 |                 if (is_pf)
      |                    ^
[572/3631] Compiling C object
drivers/libtmp_rte_net_iavf.a.p/net_intel_iavf_base_iavf_adminq.c.o
[573/3631] Compiling C object
drivers/libtmp_rte_net_dpaa.a.p/net_dpaa_dpaa_rxtx.c.o
[574/3631] Compiling C object
drivers/libtmp_rte_net_i40e.a.p/net_intel_i40e_rte_pmd_i40e.c.o
In file included from ../drivers/net/intel/i40e/rte_pmd_i40e.c:12:
../drivers/net/intel/i40e/i40e_ethdev.h: In function ‘i40e_calc_itr_interval’:
../drivers/net/intel/i40e/i40e_ethdev.h:1514:20: warning: this condition has
identical branches [-Wduplicated-branches]
 1514 |                 if (is_pf)
      |                    ^
[575/3631] Compiling C object
drivers/libtmp_rte_net_i40e.a.p/net_intel_i40e_base_i40e_nvm.c.o
[576/3631] Compiling C object
drivers/libtmp_rte_net_iavf.a.p/net_intel_iavf_iavf_tm.c.o
[577/3631] Compiling C object
drivers/libtmp_rte_net_dpaa2.a.p/net_dpaa2_dpaa2_flow.c.o
[578/3631] Compiling C object
drivers/libtmp_rte_net_iavf.a.p/net_intel_iavf_iavf_generic_flow.c.o
[579/3631] Compiling C object
drivers/libtmp_rte_net_iavf.a.p/net_intel_iavf_iavf_fdir.c.o
[580/3631] Compiling C object
drivers/libtmp_rte_net_iavf.a.p/net_intel_iavf_iavf_ipsec_crypto.c.o
[581/3631] Compiling C object
drivers/libtmp_rte_net_iavf.a.p/net_intel_iavf_iavf_hash.c.o
[582/3631] Compiling C object
drivers/libtmp_rte_net_i40e.a.p/net_intel_i40e_i40e_rxtx_vec_sse.c.o
In file included from ../drivers/net/intel/i40e/i40e_rxtx_vec_sse.c:11:
../drivers/net/intel/i40e/i40e_ethdev.h: In function ‘i40e_calc_itr_interval’:
../drivers/net/intel/i40e/i40e_ethdev.h:1514:20: warning: this condition has
identical branches [-Wduplicated-branches]
 1514 |                 if (is_pf)
      |                    ^
[583/3631] Compiling C object
drivers/libtmp_rte_net_iavf.a.p/net_intel_iavf_iavf_fsub.c.o
[584/3631] Compiling C object
drivers/libtmp_rte_net_idpf.a.p/net_intel_idpf_idpf_common_device.c.o
[585/3631] Compiling C object
drivers/libtmp_rte_net_idpf.a.p/net_intel_idpf_base_idpf_controlq_setup.c.o
[586/3631] Compiling C object
drivers/libtmp_rte_net_dpaa2.a.p/net_dpaa2_dpaa2_rxtx.c.o
[587/3631] Compiling C object
drivers/libtmp_rte_net_i40e.a.p/net_intel_i40e_base_i40e_common.c.o
../drivers/net/intel/i40e/base/i40e_common.c: In function
‘i40e_lpi_stat_update’:
../drivers/net/intel/i40e/base/i40e_common.c:7342:56: warning: this condition
has identical branches [-Wduplicated-branches]
 7342 |                         (u32)(tx_counter - *tx_offset) :
      |                                                        ^
../drivers/net/intel/i40e/base/i40e_common.c:7345:56: warning: this condition
has identical branches [-Wduplicated-branches]
 7345 |                         (u32)(rx_counter - *rx_offset) :
      |                                                        ^
[588/3631] Compiling C object
drivers/libtmp_rte_net_idpf.a.p/net_intel_idpf_base_idpf_controlq.c.o
                ^

-- 
You are receiving this mail because:
You are the assignee for the bug.