From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bugzilla@dpdk.org>
Received: by dpdk.org (Postfix, from userid 33)
 id A77915F1C; Sun,  1 Apr 2018 14:59:49 +0200 (CEST)
From: bugzilla@dpdk.org
To: dev@dpdk.org
Date: Sun, 01 Apr 2018 12:59:49 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: DPDK
X-Bugzilla-Component: ethdev
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: solal.pirelli@gmail.com
X-Bugzilla-Status: CONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: dev@dpdk.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 target_milestone
Message-ID: <bug-25-3@http.dpdk.org/tracker/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://dpdk.org/tracker/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
MIME-Version: 1.0
Subject: [dpdk-dev] [Bug 25] Ixgbe driver sets TDH register after
	TXDCTL.ENABLE is set
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Apr 2018 12:59:49 -0000

https://dpdk.org/tracker/show_bug.cgi?id=3D25

            Bug ID: 25
           Summary: Ixgbe driver sets TDH register after TXDCTL.ENABLE is
                    set
           Product: DPDK
           Version: unspecified
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: solal.pirelli@gmail.com
  Target Milestone: ---

The Intel 82599 data sheet
(https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/82=
599-10-gbe-controller-datasheet.pdf,
=C2=A78.2.3.9.8) states that "The only time that software should write to [=
the TDH]
register is after a reset (hardware reset or CTRL.RST) and before enabling =
the
transmit function (TXDCTL.ENABLE). If software were to write to this regist=
er
while the transmit function was enabled, the on-chip descriptor buffers mig=
ht
be invalidated and the hardware could become confused".

The ixgbe driver's ixgbe_dev_tx_queue_start function
(http://dpdk.org/browse/dpdk/tree/drivers/net/ixgbe/ixgbe_rxtx.c?h=3Dv18.02=
#n5148)
first enables TXDCTL.ENABLE, then performs some admirable efforts to make s=
ure
it is truly enabled, and then changes TDH, ensuring that hardware confusion=
 can
happen.

--=20
You are receiving this mail because:
You are the assignee for the bug.=