From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 33) id C6C0C1B39A; Fri, 12 Apr 2019 18:58:53 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Date: Fri, 12 Apr 2019 16:58:53 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: ethdev X-Bugzilla-Version: 18.11 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: herakliusz.lipiec@intel.com X-Bugzilla-Status: CONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 Subject: [dpdk-dev] [Bug 252] Possible access to invalid FDs in rte_eth_tap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2019 16:58:54 -0000 https://bugs.dpdk.org/show_bug.cgi?id=3D252 Bug ID: 252 Summary: Possible access to invalid FDs in rte_eth_tap Product: DPDK Version: 18.11 Hardware: All OS: All Status: CONFIRMED Severity: normal Priority: Normal Component: ethdev Assignee: dev@dpdk.org Reporter: herakliusz.lipiec@intel.com Target Milestone: --- In tap_mp_attach_queues function in rte_eth_tap.c we iterate over a queue of fds received through IPC and we dont check if they are valid FDs before assigning them to txq and rxq. There is also no check for number of received messages (there could be none if IPC is disabled so checking of the return = code is not enough). Present in 18.11, 19.02 and 19.05rc1. --=20 You are receiving this mail because: You are the assignee for the bug.= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id EE69FA0096 for ; Fri, 12 Apr 2019 18:58:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8FA381B2AD; Fri, 12 Apr 2019 18:58:55 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 33) id C6C0C1B39A; Fri, 12 Apr 2019 18:58:53 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Date: Fri, 12 Apr 2019 16:58:53 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: ethdev X-Bugzilla-Version: 18.11 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: herakliusz.lipiec@intel.com X-Bugzilla-Status: CONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 Subject: [dpdk-dev] [Bug 252] Possible access to invalid FDs in rte_eth_tap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190412165853.5QdDApgoMjf5LrD77-4YP1D8G7lt97IS8P7YOzney9A@z> https://bugs.dpdk.org/show_bug.cgi?id=3D252 Bug ID: 252 Summary: Possible access to invalid FDs in rte_eth_tap Product: DPDK Version: 18.11 Hardware: All OS: All Status: CONFIRMED Severity: normal Priority: Normal Component: ethdev Assignee: dev@dpdk.org Reporter: herakliusz.lipiec@intel.com Target Milestone: --- In tap_mp_attach_queues function in rte_eth_tap.c we iterate over a queue of fds received through IPC and we dont check if they are valid FDs before assigning them to txq and rxq. There is also no check for number of received messages (there could be none if IPC is disabled so checking of the return = code is not enough). Present in 18.11, 19.02 and 19.05rc1. --=20 You are receiving this mail because: You are the assignee for the bug.=