* [dpdk-dev] [Bug 282] Fix missing headers in FreeBSD CURRENT build
@ 2019-05-21 1:54 bugzilla
2019-05-21 3:04 ` Stephen Hemminger
2019-07-12 16:07 ` bugzilla
0 siblings, 2 replies; 3+ messages in thread
From: bugzilla @ 2019-05-21 1:54 UTC (permalink / raw)
To: dev
https://bugs.dpdk.org/show_bug.cgi?id=282
Bug ID: 282
Summary: Fix missing headers in FreeBSD CURRENT build
Product: DPDK
Version: 18.05
Hardware: All
OS: FreeBSD
Status: CONFIRMED
Severity: normal
Priority: Normal
Component: core
Assignee: dev@dpdk.org
Reporter: cem@FreeBSD.org
Target Milestone: ---
After header pollution cleanup, some files in DPDK 18.05.1 no longer compile.
The fixes are straightforward. I don't know if the problem is still present in
newer DPDK but I wouldn't be surprised if it were. Feel free to consider these
patches in the public domain, or CC0 if you're European:
--- kernel/freebsd/contigmem/contigmem.c.orig 2018-09-05 14:29:02 UTC
+++ kernel/freebsd/contigmem/contigmem.c
@@ -9,9 +9,12 @@
#include <sys/bio.h>
#include <sys/bus.h>
#include <sys/conf.h>
+#include <sys/eventhandler.h>
#include <sys/kernel.h>
+#include <sys/lock.h>
#include <sys/malloc.h>
#include <sys/module.h>
+#include <sys/mutex.h>
#include <sys/proc.h>
#include <sys/rwlock.h>
#include <sys/systm.h>
--- kernel/freebsd/nic_uio/nic_uio.c.orig 2018-09-05 14:29:02 UTC
+++ kernel/freebsd/nic_uio/nic_uio.c
@@ -9,6 +9,7 @@
#include <sys/kernel.h> /* types used in module initialization */
#include <sys/conf.h> /* cdevsw struct */
#include <sys/bus.h> /* structs, prototypes for pci bus stuff and DEVMETHOD */
+#include <sys/lock.h> /* used by vm_pager.h => MPASS() */
#include <sys/rman.h>
#include <sys/systm.h>
#include <sys/rwlock.h>
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [Bug 282] Fix missing headers in FreeBSD CURRENT build
2019-05-21 1:54 [dpdk-dev] [Bug 282] Fix missing headers in FreeBSD CURRENT build bugzilla
@ 2019-05-21 3:04 ` Stephen Hemminger
2019-07-12 16:07 ` bugzilla
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2019-05-21 3:04 UTC (permalink / raw)
To: bugzilla; +Cc: dev
On Tue, 21 May 2019 01:54:36 +0000
bugzilla@dpdk.org wrote:
> https://bugs.dpdk.org/show_bug.cgi?id=282
>
> Bug ID: 282
> Summary: Fix missing headers in FreeBSD CURRENT build
> Product: DPDK
> Version: 18.05
> Hardware: All
> OS: FreeBSD
> Status: CONFIRMED
> Severity: normal
> Priority: Normal
> Component: core
> Assignee: dev@dpdk.org
> Reporter: cem@FreeBSD.org
> Target Milestone: ---
>
> After header pollution cleanup, some files in DPDK 18.05.1 no longer compile.
> The fixes are straightforward. I don't know if the problem is still present in
> newer DPDK but I wouldn't be surprised if it were. Feel free to consider these
> patches in the public domain, or CC0 if you're European:
>
All patches must be licensed by the same license as the original code.
That is BSD-3 in this case.
Please don't send with other licenses.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-dev] [Bug 282] Fix missing headers in FreeBSD CURRENT build
2019-05-21 1:54 [dpdk-dev] [Bug 282] Fix missing headers in FreeBSD CURRENT build bugzilla
2019-05-21 3:04 ` Stephen Hemminger
@ 2019-07-12 16:07 ` bugzilla
1 sibling, 0 replies; 3+ messages in thread
From: bugzilla @ 2019-07-12 16:07 UTC (permalink / raw)
To: dev
https://bugs.dpdk.org/show_bug.cgi?id=282
Conrad Meyer (cem@FreeBSD.org) changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #6 from Conrad Meyer (cem@FreeBSD.org) ---
(In reply to Herakliusz from comment #5)
> This issue had been fixed
> on 19.08. As I said before 18.05 is no longer supported so there will be no
> back-port to 18.05 but more than likely this will get back-ported to 18.11
> LTS as well.
Right, 1c7191e7349e612a44523cde7fa2340ffe8f1c8f works for me. I just want it
fixed in the development branch; I don't care about 18.05 or any LTS release in
particular. Thanks Bruce Richardson!
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-12 16:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-21 1:54 [dpdk-dev] [Bug 282] Fix missing headers in FreeBSD CURRENT build bugzilla
2019-05-21 3:04 ` Stephen Hemminger
2019-07-12 16:07 ` bugzilla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).