From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [dpdk-dev] [Bug 345] rte_hash returns invalid key if the number of entries is not a power of 2
Date: Thu, 05 Sep 2019 15:40:44 +0000 [thread overview]
Message-ID: <bug-345-3@http.bugs.dpdk.org/> (raw)
https://bugs.dpdk.org/show_bug.cgi?id=345
Bug ID: 345
Summary: rte_hash returns invalid key if the number of entries
is not a power of 2
Product: DPDK
Version: 19.08
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: other
Assignee: dev@dpdk.org
Reporter: barbette@kth.se
Target Milestone: ---
Hi all,
rte_hash_create will silently augment the number of entries (N) to the next
power of 2 value.
Per the documentation, the return values of "rte_hash_lookup" or "rte_hash_add"
is "[... or] a positive value that can be used by the caller as an offset into
an array of user data. This value is unique for this key.".
Which may lead to a segmentation fault, as the user allocated only N entries
and not next_pow2(N). And there is no means to recover what is the "final"
number of entries (next_pow2(N)).
I would suggest to at least update the documentation. One way to really fix
this would be to let the user get the actual number of entries, or fail if the
value is not a power of 2.
Tom
--
You are receiving this mail because:
You are the assignee for the bug.
reply other threads:[~2019-09-05 15:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-345-3@http.bugs.dpdk.org/ \
--to=bugzilla@dpdk.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).