DPDK patches and discussions
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [dpdk-dev] [Bug 430] i40e has wrong byte order in rte_flow_item_eth (ethdev)
Date: Sun, 29 Mar 2020 14:48:37 +0000	[thread overview]
Message-ID: <bug-430-3@http.bugs.dpdk.org/> (raw)

https://bugs.dpdk.org/show_bug.cgi?id=430

            Bug ID: 430
           Summary: i40e has wrong byte order in rte_flow_item_eth
                    (ethdev)
           Product: DPDK
           Version: 20.02
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: barbette@kth.se
                CC: arybchenko@solarflare.com, beilei.xing@intel.com,
                    qi.z.zhang@intel.com, thomas@monjalon.net
  Target Milestone: 20.05

Following a recent discussion on the mailing list, I'm opening this bug because
rte_flow_item_eth takes its ethertype in host byte order with
i40e, while it should be in network byte order.

In consequence, with testpmd one must give the inverted endianness for the
ethertype :
testpmd> flow create 0 ingress pattern eth type is 0x0800 / end actions mark id
5  / end
port_flow_complain(): Caught PMD error type 13 (specific pattern item): cause:
0x227fd75540, Unsupported ether_type.: Invalid argument
testpmd> flow create 0 ingress pattern eth type is 0x0008 / end actions mark id
5  / end
Flow rule #0 created

I only tested the ethertype, but it may affect other fields?

As per Andrew Rybchenko's comment, the type of rte_flow_item_eth is rte_be16_t
so the correct behaviour is network byte order.

-- 
You are receiving this mail because:
You are the assignee for the bug.

                 reply	other threads:[~2020-03-29 14:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-430-3@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).