DPDK patches and discussions
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [dpdk-dev] [Bug 484] rte_sched_subport_free function does not free subport memory
Date: Fri, 22 May 2020 13:26:14 +0000	[thread overview]
Message-ID: <bug-484-3@http.bugs.dpdk.org/> (raw)

https://bugs.dpdk.org/show_bug.cgi?id=484

            Bug ID: 484
           Summary: rte_sched_subport_free function does not free subport
                    memory
           Product: DPDK
           Version: 19.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: other
          Assignee: dev@dpdk.org
          Reporter: hrvoje.habjanic@zg.ht.hr
  Target Milestone: ---

Created attachment 105
  --> https://bugs.dpdk.org/attachment.cgi?id=105&action=edit
Patch to fix rte_sched_subport_free leak

Hi.

It would seem that rte_sched_subport_free does not properly free allocated
subport memory.

In function rte_sched_subport_free (lib/librte_sched/rte_sched.c, line 865),
there is code to free all allocated stuff related to scheduler subport. First
there are some checks, and in the end, rte_bitmap_free is called.

Now, rte_bitmap_free is a dummy function, and it just checks if provided
pointer to bitmap is valid or not. So, actual memory for subport is not freed,
and this is shown as memory leak.

Fix is quite simple, rte_bitmap_free should be replaced with rte_free, and
argument should be changed to subport pointer.

Regards,

H.

-- 
You are receiving this mail because:
You are the assignee for the bug.

                 reply	other threads:[~2020-05-22 13:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-484-3@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).