DPDK patches and discussions
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [dpdk-dev] [Bug 485] pipe_profile_check function have wrong argument size
Date: Fri, 22 May 2020 19:56:12 +0000	[thread overview]
Message-ID: <bug-485-3@http.bugs.dpdk.org/> (raw)

https://bugs.dpdk.org/show_bug.cgi?id=485

            Bug ID: 485
           Summary: pipe_profile_check function have wrong argument size
           Product: DPDK
           Version: 19.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: other
          Assignee: dev@dpdk.org
          Reporter: hrvoje.habjanic@zg.ht.hr
  Target Milestone: ---

Created attachment 106
  --> https://bugs.dpdk.org/attachment.cgi?id=106&action=edit
Correct rate argument of pipe_profile_check function

Hi.

Function pipe_profile_check (in lib/librte_sched/rte_sched.c, line 306) is used
to check for correct parameters in pipe profile. One of checks is to ensure
that pipe profile rate is equal or below subport rate. Subport rate is provided
as function argument.

In case that port and subport rate is set to 40G, pipe_profile_check fails
because 40G converted to bytes is bigger that uint32 which is used for check.

Fix is simple, and just requires that rate argument of pipe_profile_check
should be changed to uint64_t.

Regards,

H.

-- 
You are receiving this mail because:
You are the assignee for the bug.

                 reply	other threads:[~2020-05-22 19:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-485-3@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).