DPDK patches and discussions
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [dpdk-dev] [Bug 516] Multiple Intel Ethernet drivers do not conform to rte_eth_rx_burst() API
Date: Mon, 27 Jul 2020 09:29:15 +0000	[thread overview]
Message-ID: <bug-516-3@http.bugs.dpdk.org/> (raw)

https://bugs.dpdk.org/show_bug.cgi?id=516

            Bug ID: 516
           Summary: Multiple Intel Ethernet drivers do not conform to
                    rte_eth_rx_burst() API
           Product: DPDK
           Version: unspecified
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: mb@smartsharesystems.com
  Target Milestone: ---

When calling rte_eth_rx_burst() with nb_pkts > 32, many of the receive function
implementations in the Intel Ethernet drivers only return 32 packets, but they
must return all available packets, up to nb_pkts.

The API description of rte_eth_rx_burst() says:

<quote>
The rte_eth_rx_burst() function returns the number of packets actually
retrieved, which is the number of rte_mbuf data structures effectively supplied
into the rx_pkts array. A return value equal to nb_pkts indicates that the RX
queue contained at least rx_pkts packets, and this is likely to signify that
other received packets remain in the input queue. Applications implementing a
"retrieve as much received packets as possible" policy can check this specific
case and keep invoking the rte_eth_rx_burst() function until a value less than
nb_pkts is returned.
</quote>

The driver implementation does not conform to the documented behavior for
"retrieve as much received packets as possible" applications.


I initially ran into this bug on the ixgbe driver using the SSE vector receive
routine.

It looks like some of the receive function implementations in most of the Intel
Ethernet drivers assume that rte_eth_rx_burst() will not be called with nb_pkts
> 32.

Looking at the source code, at least the ixgbe, i40e and fm10k drivers have the
same bug.

Originally posted on the mailing list:
http://inbox.dpdk.org/dev/98CBD80474FA8B44BF855DF32C47DC35C61127@smartserver.smartshare.dk/

-- 
You are receiving this mail because:
You are the assignee for the bug.

                 reply	other threads:[~2020-07-27  9:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-516-3@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).