DPDK patches and discussions
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [dpdk-dev] [Bug 549] With offloads, bond device initialization fails with command-line bond arguments
Date: Fri, 09 Oct 2020 18:23:03 +0000	[thread overview]
Message-ID: <bug-549-3@http.bugs.dpdk.org/> (raw)

https://bugs.dpdk.org/show_bug.cgi?id=549

            Bug ID: 549
           Summary: With offloads, bond device initialization fails with
                    command-line bond arguments
           Product: DPDK
           Version: 20.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: eventdev
          Assignee: dev@dpdk.org
          Reporter: kiran.kn80@gmail.com
  Target Milestone: ---

In Tungsten fabric, we are trying to initialize bond device using the
command-line vdev argument - 

"--vdev
eth_bond_bond0,mode=4,xmit_policy=l34,socket_id=0,mac=00:1b:21:bb:f9:48,lacp_rate=0,slave=0000:02:00.0,slave=0000:02:00.1"

We have the bond device offloads set - DEV_RX_OFFLOAD_CHECKSUM and
DEV_RX_OFFLOAD_JUMBO_FRAME

It fails here -
https://github.com/DPDK/dpdk/blob/main/lib/librte_ethdev/rte_ethdev.c#L1378

In DPDK 18.05, this "return" was not present, but it's added in DPDK 19.11.

The reason it fails there is because bond inherits offloads from slave. But in
case where command-line arguments are present for the bond, the slave is
initialized from the bond driver later and so it is not initialized. Due to
this, offloads are not inherited to the bond device and the above check fails.

I have discussed this with Doherty, Declan <declan.doherty@intel.com> and he
agrees this needs to be fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

                 reply	other threads:[~2020-10-09 18:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-549-3@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).