From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F300A04B7; Wed, 14 Oct 2020 12:02:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3EA6D1DDC1; Wed, 14 Oct 2020 12:02:24 +0200 (CEST) Received: from inbox.dpdk.org (xvm-172-178.dc0.ghst.net [95.142.172.178]) by dpdk.org (Postfix) with ESMTP id 3749B1DCDC for ; Wed, 14 Oct 2020 12:02:22 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id 271A5A04C0; Wed, 14 Oct 2020 12:02:22 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Date: Wed, 14 Oct 2020 10:02:20 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: testpmd X-Bugzilla-Version: 20.11 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: linglix.chen@intel.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 Subject: [dpdk-dev] [Bug 554] shutdown_api/test_change_thresholds: Port config all rxpt, rxht, rxwt are invalid X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" https://bugs.dpdk.org/show_bug.cgi?id=3D554 Bug ID: 554 Summary: shutdown_api/test_change_thresholds: Port config all rxpt, rxht, rxwt are invalid Product: DPDK Version: 20.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: Normal Component: testpmd Assignee: dev@dpdk.org Reporter: linglix.chen@intel.com Target Milestone: --- Created attachment 124 --> https://bugs.dpdk.org/attachment.cgi?id=3D124&action=3Dedit shutdown_api/test_change_thresholds-FAILED-log Environment: =E2=80=A2DPDK version: 20.11.0-rc0 commit 700ded7aa15f5ecc5b68d12fcb6fd3bf= e06e599d =E2=80=A2OS: CentOS8.2/4.18.0-193.6.3.el8_2.x86_64 =E2=80=A2Compiler: gcc 8.3.1 =E2=80=A2Hardware platform: Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz =E2=80=A2NIC hardware: 82599ES 10-Gigabit SFI/SFP+ Network Connection 10fb =E2=80=A2NIC firmware: 0x000161bf =E2=80=A2NIC driver version: 5.1.0-k-rh8.2.0 Steps to reproduce: 1. Bind 2 PFs to vfio-pci.=20 #dpdk-devbind.py --force --bind=3Dvfio-pci 0000:81:00.0 0000:81:00.1=20 2. Launch testpmd.=20 #x86_64-native-linuxapp-gcc/app/dpdk-testpmd -l 1,2 -n 4 -w 0000:81:00.0 -w 0000:81:00.1 --file-prefix=3Ddpdk_10376_20201015182508 -- -i --portmask=3D0= x1 --port-topology=3Dloop=20 testpmd> set promisc all off=20 testpmd> port stop all=20 testpmd> port config all rxpt 64 testpmd> port config all rxht 64 testpmd> port config all rxwt 64=20 testpmd> port start all=20 testpmd> show config rxtx Actual Result: port 0: RX queue number: 1 Tx queue number: 1 Rx offloads=3D0x0 Tx offloads=3D0x0 RX queue: 0 RX desc=3D256 - RX free threshold=3D32 RX threshold registers: pthresh=3D0 hthresh=3D0 wthresh=3D0 RX Offloads=3D0x0 TX queue: 0 TX desc=3D256 - TX free threshold=3D32 TX threshold registers: pthresh=3D64 hthresh=3D64 wthresh=3D0 TX offloads=3D0x0 - TX RS bit threshold=3D32 port 1: RX queue number: 1 Tx queue number: 1 Rx offloads=3D0x0 Tx offloads=3D0x0 RX queue: 0 RX desc=3D256 - RX free threshold=3D32 RX threshold registers: pthresh=3D0 hthresh=3D0 wthresh=3D0 RX Offloads=3D0x0 TX queue: 0 TX desc=3D256 - TX free threshold=3D32 TX threshold registers: pthresh=3D64 hthresh=3D64 wthresh=3D0 TX offloads=3D0x0 - TX RS bit threshold=3D32 Expected Result: port 0: RX queue number: 1 Tx queue number: 1 Rx offloads=3D0x0 Tx offloads=3D0x0 RX queue: 0 RX desc=3D256 - RX free threshold=3D32 RX threshold registers: pthresh=3D64 hthresh=3D64 wthresh=3D64 RX Offloads=3D0x0 TX queue: 0 TX desc=3D256 - TX free threshold=3D32 TX threshold registers: pthresh=3D64 hthresh=3D64 wthresh=3D0 TX offloads=3D0x0 - TX RS bit threshold=3D32 port 1: RX queue number: 1 Tx queue number: 1 Rx offloads=3D0x0 Tx offloads=3D0x0 RX queue: 0 RX desc=3D256 - RX free threshold=3D32 RX threshold registers: pthresh=3D64 hthresh=3D64 wthresh=3D64 RX Offloads=3D0x0 TX queue: 0 TX desc=3D256 - TX free threshold=3D32 TX threshold registers: pthresh=3D64 hthresh=3D64 wthresh=3D0=20=20= =20=20=20 TX offloads=3D0x0 - TX RS bit threshold=3D32=20 Regression: Is this issue a regression: Y First bad commit: commit 700ded7aa15f5ecc5b68d12fcb6fd3bfe06e599d (HEAD -> master) Author: Huisong Li Date: Fri Sep 25 20:47:19 2020 +0800 app/testpmd: fix displaying Rx/Tx queues information Currently, the information of Rx/Tx queues from PMD driver is not displayed exactly in the rxtx_config_display function. Because "ports[pid].rx_conf" and "ports[pid].tx_conf" maintained in testpmd application may be not the value actually used by PMD driver. For instance, user does not set a field, but PMD driver has to use the default value. This patch fixes rxtx_config_display so that the information of Rx/Tx queues can be really displayed for the PMD driver that implement .rxq_info_get and .txq_info_get ops callback function. Fixes: 75c530c1bd53 ("app/testpmd: fix port configuration print") Fixes: d44f8a485f5d ("app/testpmd: enable per queue configure") Cc: stable@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) Reviewed-by: Ferruh Yigit --=20 You are receiving this mail because: You are the assignee for the bug.=