From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78803A0561; Fri, 5 Mar 2021 00:09:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1189F4069F; Fri, 5 Mar 2021 00:09:27 +0100 (CET) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id 4D87E40692 for ; Fri, 5 Mar 2021 00:09:25 +0100 (CET) Received: by inbox.dpdk.org (Postfix, from userid 33) id 250DCA0562; Fri, 5 Mar 2021 00:09:25 +0100 (CET) From: bugzilla@dpdk.org To: dev@dpdk.org Date: Thu, 04 Mar 2021 23:09:24 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: ethdev X-Bugzilla-Version: 20.11 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mgsmith@netgate.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 Subject: [dpdk-dev] [Bug 648] i40e source pruning causes packets to be dropped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" https://bugs.dpdk.org/show_bug.cgi?id=3D648 Bug ID: 648 Summary: i40e source pruning causes packets to be dropped Product: DPDK Version: 20.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: Normal Component: ethdev Assignee: dev@dpdk.org Reporter: mgsmith@netgate.com Target Milestone: --- Created attachment 146 --> https://bugs.dpdk.org/attachment.cgi?id=3D146&action=3Dedit patch Using DPDK 20.11 with X710 or XL710 NICs, if a VRRP virtual MAC address is added to a port using rte_eth_dev_mac_addr_add(), advertisements from a hig= her priority VRRP peer which are received on that port are dropped by the NIC before the software gets a chance to see them because the inbound packets originate from the same source MAC address which was added. This breaks VRR= P. The issue has been reported on DPDK dev mailing list a couple of years ago (http://mails.dpdk.org/archives/users/2018-May/003128.html), but is still present. It also seems to affect linux kernel networking with i40e devices (https://lore.kernel.org/lkml/20200831103512.00001fab@intel.com/), though t= here is a workaround available for kernel networking. Running 'ethtool --set-priv-flags ethX disable-source-pruning on' prevents the packets from being dropped. There is no available method that I have found to disable source pruning in= the DPDK i40e driver. Can one be added? Or can the default behavior be changed = so that it is not enabled by default?=20 Using linux kernel networking, the kernel source code that is called when t= his flag is set is here https://github.com/torvalds/linux/blob/3cb60ee6323968b694208c4cbd56a7176396= e931/drivers/net/ethernet/intel/i40e/i40e_main.c#L13548. Adding a patch to invoke similar logic to my local DPDK build corrected the problem. My patch just did this unconditionally since there's no flag to indicate that source pruning should be disabled in the DPDK i40e driver. I = will attach the patch that I used. The problem was observed in VPP (https://gerrit.fd.io/r/gitweb?p=3Dvpp.git;a=3Dsummary) version 21.01 using= the VRRP plugin. It was reported by multiple users. It affects both X710 and XL= 710 devices and was observed on both bare metal and using PCI passthrough on VMware. I reproduced the issue on a VMware VM using PCI passthrough with an X710 and tested with the attached patch to correct the issue. --=20 You are receiving this mail because: You are the assignee for the bug.=