From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [dpdk-dev] [Bug 665] i40e MBUF_FAST_FREE wrong check
Date: Wed, 24 Mar 2021 22:59:39 +0000 [thread overview]
Message-ID: <bug-665-3@http.bugs.dpdk.org/> (raw)
https://bugs.dpdk.org/show_bug.cgi?id=665
Bug ID: 665
Summary: i40e MBUF_FAST_FREE wrong check
Product: DPDK
Version: 20.05
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: ethdev
Assignee: dev@dpdk.org
Reporter: sbaranoff@gmail.com
Target Milestone: ---
In i40e_rxtx.c in i40e_set_tx_function_flag there's an assignment to
ad->tx_simple_allowed that includes a check for enabling "tx_simple_allowed":
txq->offloads == (txq->offloads & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
This appears to be wrong to me. If no offload flags are set then 0 == 0 &
<anything> is true. This means that if DEV_TX_OFFLOAD_MBUF_FAST_FREE is NOT set
(and no other flags are set) then this check will still enable
`tx_simple_allowed`.
As best I can tell, this causes an issue with multiple mbuf pools are being
used to feed a single TX queue and no offload flags enable.
--
You are receiving this mail because:
You are the assignee for the bug.
reply other threads:[~2021-03-24 22:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-665-3@http.bugs.dpdk.org/ \
--to=bugzilla@dpdk.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).