From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [dpdk-dev] [Bug 668] DPDK power governor fails if base_frequency is not opened
Date: Mon, 29 Mar 2021 09:57:19 +0000 [thread overview]
Message-ID: <bug-668-3@http.bugs.dpdk.org/> (raw)
https://bugs.dpdk.org/show_bug.cgi?id=668
Bug ID: 668
Summary: DPDK power governor fails if base_frequency is not
opened
Product: DPDK
Version: 20.11
Hardware: x86
OS: Linux
Status: UNCONFIRMED
Severity: major
Priority: Normal
Component: other
Assignee: dev@dpdk.org
Reporter: michallinuxstuff@gmail.com
Target Milestone: ---
DPDK fails to initialize pstate cpufreq in case base_frequency is missing from
sysfs under given cpu. This is a bit problematic now since this particular attr
exists only under specific conditions: active intel_pstate + HWP supported by
the cpu. Also, from the commit itself (4db9587bbf) it looks like this was put
in place by accident since the part which accepts missing base_frequency (and
which sets it to 0) still exists, i.e.:
snprintf(fullpath_base, sizeof(fullpath_base), POWER_SYSFILE_BASE_FREQ,
pi->lcore_id);
f_base = fopen(fullpath_base, "r");
FOPEN_OR_ERR_RET(f_base, -1); /* <- point of failure */
if (f_base == NULL) {
/* No sysfs base_frequency, that's OK, continue without */
base_ratio = 0;
Initially noticed under https://github.com/spdk/spdk/issues/1859.
Any feedback on the matter would be appreciate. :)
--
You are receiving this mail because:
You are the assignee for the bug.
reply other threads:[~2021-03-29 9:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-668-3@http.bugs.dpdk.org/ \
--to=bugzilla@dpdk.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).