From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0548BA0524;
	Wed, 14 Apr 2021 08:39:10 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 86511161702;
	Wed, 14 Apr 2021 08:39:09 +0200 (CEST)
Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178])
 by mails.dpdk.org (Postfix) with ESMTP id 67AEE161701
 for <dev@dpdk.org>; Wed, 14 Apr 2021 08:39:08 +0200 (CEST)
Received: by inbox.dpdk.org (Postfix, from userid 33)
 id 402B6A0562; Wed, 14 Apr 2021 08:39:08 +0200 (CEST)
From: bugzilla@dpdk.org
To: dev@dpdk.org
Date: Wed, 14 Apr 2021 06:39:07 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: DPDK
X-Bugzilla-Component: ethdev
X-Bugzilla-Version: 20.11
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: tudor.cornea@gmail.com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: dev@dpdk.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 target_milestone attachments.created
Message-ID: <bug-675-3@http.bugs.dpdk.org/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
MIME-Version: 1.0
Subject: [dpdk-dev] [Bug 675] net/ice: possible integer overflow when
 computing max_pkt_len
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

https://bugs.dpdk.org/show_bug.cgi?id=3D675

            Bug ID: 675
           Summary: net/ice: possible integer overflow when computing
                    max_pkt_len
           Product: DPDK
           Version: 20.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: tudor.cornea@gmail.com
  Target Milestone: ---

Created attachment 155
  --> https://bugs.dpdk.org/attachment.cgi?id=3D155&action=3Dedit
Patch with possible fix

Greetings,

While working with the Intel ice driver (E810 NIC), I have stumbled into, w=
hat
I think to be a bug, which is causing all Jumbo Frames to get dropped.=20

I think that the len variable, used in the computation of max_pkt_len could
overflow, if used to store the result of the following computation:

ICE_SUPPORT_CHAIN_NUM * rxq->rx_buf_len

Since, we could define the mbuf size to have a large value (i.e 13312),
and ICE_SUPPORT_CHAIN_NUM is defined as 5, the computation mentioned above,
could potentially result in a value which might be bigger than MAX_USHORT.

The result will be that Jumbo Frames will not work properly

Could you please review the following pull request (I have also added the p=
atch
as an attachment) ?


[1] https://github.com/DPDK/dpdk/pull/29

--=20
You are receiving this mail because:
You are the assignee for the bug.=