From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7ADD8A0547;
	Fri, 29 Oct 2021 07:52:56 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 22A1840DDB;
	Fri, 29 Oct 2021 07:52:56 +0200 (CEST)
Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178])
 by mails.dpdk.org (Postfix) with ESMTP id 1A06740688
 for <dev@dpdk.org>; Fri, 29 Oct 2021 07:52:55 +0200 (CEST)
Received: by inbox.dpdk.org (Postfix, from userid 33)
 id ED906A0C41; Fri, 29 Oct 2021 07:52:54 +0200 (CEST)
From: bugzilla@dpdk.org
To: dev@dpdk.org
Date: Fri, 29 Oct 2021 05:52:54 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: DPDK
X-Bugzilla-Component: core
X-Bugzilla-Version: 21.11
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: leweix.yang@intel.com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: dev@dpdk.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 target_milestone
Message-ID: <bug-864-3@http.bugs.dpdk.org/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
MIME-Version: 1.0
Subject: [dpdk-dev] [Bug 864]
 [dpdk-21.11]pmd_stacked_bonded/test_mode_backup_rx:after setup stacked
 bonded ports, start top level bond port failed
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

https://bugs.dpdk.org/show_bug.cgi?id=3D864

            Bug ID: 864
           Summary: [dpdk-21.11]pmd_stacked_bonded/test_mode_backup_rx:aft
                    er setup stacked bonded ports,start top level bond
                    port failed
           Product: DPDK
           Version: 21.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: core
          Assignee: dev@dpdk.org
          Reporter: leweix.yang@intel.com
  Target Milestone: ---

DPDK version: Use make showversion or for a non-released version: git remot=
e -v
&& git show-ref --heads
 21.11-rc1:6c390cee976e33b1e9d8562d32c9d3ebe5d9ce94
Other software versions: name/version for QEMU, OVS, etc. Repeat as require=
d.
OS: Red Hat Enterprise Linux 8.4 4.18.0-305.19.1.el8_4.x86_64=20
Compiler: gcc (GCC) 8.4.1 20200928 (Red Hat 8.4.1-1)
Hardware platform: Intel(R) Xeon(R) Gold 6252N CPU @ 2.30GHz.
NIC hardware: Ethernet Controller XXV710 for 25GbE SFP28 158b
NIC firmware: 8.30 0x8000a485 1.2926.0
Device version: 2.17.1


Test Setup
Steps to reproduce
List the steps to reproduce the issue.

1.build dpdk=20
# CC=3Dgcc meson -Denable_kmods=3DTrue -Dlibdir=3Dlib  --default-library=3D=
static
x86_64-native-bsdapp-gcc
# ninja -C x86_64-native-bsdapp-gcc
2.lanch app
# x86_64-native-linuxapp-gcc/app/dpdk-testpmd -l
1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,49,50,51,52,53,=
54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71
-n 4 -a 0000:af:00.0 -a 0000:af:00.1 --file-prefix=3Ddpdk_875252_2021102709=
4057 =E2=80=93
-i
3.execute dpdk command=20
# port stop all
# create bonded device 1 1
# add bonding slave 0 2
# create bonded device 1 1
# add bonding slave 1 3
# create bonded device 1 1
# add bonding slave 2 4
# add bonding slave 3 4
# set portlist 0,1,2,3,4
# port start 4



Show the output from the previous commands:

# testpmd>port start 4
Configuring Port 4 (socket 1)
Device with port_id=3D2 already stopped
Port 2 must be configured before MTU set
slave_configure(1741) - rte_eth_dev_set_mtu: port 2, err (-22)
bond_ethdev_start(1994) - bonded port (4) failed to reconfigure slave device
(2)
Fail to start port 4: Operation not permitted
Please stop the ports first
Done
testpmd>



Expected Result
Explain what is the expected result in text or as an example output:

# execute success
Regression
Is this issue a regression: (Y/N) Y

git show b26bee10ee37ac2e54011f7bd57ca806bd9f8f6c
commit b26bee10ee37ac2e54011f7bd57ca806bd9f8f6c
Author: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>
Date: Fri Oct 22 13:18:28 2021 +0300

ethdev: forbid MTU set before device configure

rte_eth_dev_configure() always sets MTU to either dev_conf.rxmode.mtu
or RTE_ETHER_MTU if application doesn't provide the value.
So, there is no point to allow rte_eth_dev_set_mtu() before since
set value will be overwritten on configure anyway.

Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length")

Signed-off-by: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

--=20
You are receiving this mail because:
You are the assignee for the bug.=