From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4E030A0C5C;
	Fri, 26 Nov 2021 13:03:53 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 18F1F40C35;
	Fri, 26 Nov 2021 13:03:53 +0100 (CET)
Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178])
 by mails.dpdk.org (Postfix) with ESMTP id B0E91406FF
 for <dev@dpdk.org>; Fri, 26 Nov 2021 13:03:51 +0100 (CET)
Received: by inbox.dpdk.org (Postfix, from userid 33)
 id 9694DA0C5D; Fri, 26 Nov 2021 13:03:51 +0100 (CET)
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [Bug 890] lib/ip_frag: IPv4 options without copied bit set are
 present in all fragments
Date: Fri, 26 Nov 2021 12:03:51 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: DPDK
X-Bugzilla-Component: other
X-Bugzilla-Version: 21.11
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: minor
X-Bugzilla-Who: dsosnowski@nvidia.com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: dev@dpdk.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 target_milestone
Message-ID: <bug-890-3@http.bugs.dpdk.org/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
MIME-Version: 1.0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

https://bugs.dpdk.org/show_bug.cgi?id=3D890

            Bug ID: 890
           Summary: lib/ip_frag: IPv4 options without copied bit set are
                    present in all fragments
           Product: DPDK
           Version: 21.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: minor
          Priority: Normal
         Component: other
          Assignee: dev@dpdk.org
          Reporter: dsosnowski@nvidia.com
  Target Milestone: ---

As of 21.11-rc4 ip_fragmentation library implementation for IPv4 seems to
ignore "copied" bit of IPv4 options. IPv4 options are copied over to all
fragments regardless of "copied" bit set to 0.

Setup assumptions:

1) Two machines:
1.1) Machine A, with two ports, running dpdk-ip_fragmentation example
application.
1.2) Machine B, with two ports, running scapy. Acts as a traffic generator.

Steps to reproduce:

1) Start examples/dpdk-ip_fragmentation application on machine A:

```
sudo ./build/examples/dpdk-ip_fragmentation -a 08:00.0 -a 08:00.1 -- -p 0x3=
 -q
1
```

2) Start sniffing for traffic using scapy on machine B:
3) Using scapy send a following packet, IP packet with additional NOP option
with copy flag set to 0, from machine B:

```
packet =3D (
    Ether(src=3D'0c:42:a1:d1:d1:8c', dst=3D'0c:42:a1:d1:d0:48') /
    IP(src=3D'100.10.0.1', dst=3D'100.20.0.1', options=3D[IPOption(option=
=3D1,
copy_flag=3D0), IPOption(option=3D0, copy_flag=3D0)]) /
    UDP(sport=3D55555, dport=3D12345) /
    Raw(load=3Db'a' * 2000)
)
```

What should happen:

1) Machine B should receive two IP fragments:
1.1) 1st fragment with IP options present.
1.2) 2nd fragment without IP options.

What actually happens:

1) Machine B receives two IP fragments with IP options present.

--=20
You are receiving this mail because:
You are the assignee for the bug.=