From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id ECDCFA034F;
	Tue,  1 Mar 2022 07:59:19 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BB4D140DF6;
	Tue,  1 Mar 2022 07:59:19 +0100 (CET)
Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178])
 by mails.dpdk.org (Postfix) with ESMTP id 5BBE0407FF
 for <dev@dpdk.org>; Tue,  1 Mar 2022 07:59:18 +0100 (CET)
Received: by inbox.dpdk.org (Postfix, from userid 33)
 id 4F18FA0350; Tue,  1 Mar 2022 07:59:18 +0100 (CET)
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [Bug 942] i40e: condition in `i40e_flow_parse_fdir_pattern()` is
 always false
Date: Tue, 01 Mar 2022 06:59:18 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: DPDK
X-Bugzilla-Component: ethdev
X-Bugzilla-Version: 21.11
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: Stepan.Repin@infotecs.ru
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: dev@dpdk.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 target_milestone
Message-ID: <bug-942-3@http.bugs.dpdk.org/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
MIME-Version: 1.0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

https://bugs.dpdk.org/show_bug.cgi?id=3D942

            Bug ID: 942
           Summary: i40e: condition in `i40e_flow_parse_fdir_pattern()` is
                    always false
           Product: DPDK
           Version: 21.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: Stepan.Repin@infotecs.ru
  Target Milestone: ---

`i40e_flow.c` contains the following code processing `RTE_FLOW_ITEM_TYPE_ET=
H`
in the function
`i40e_flow_parse_fdir_pattern()` [1]:

        if (eth_spec && eth_mask && next_type =3D=3D RTE_FLOW_ITEM_TYPE_END=
) {
                ...
                if (next_type =3D=3D RTE_FLOW_ITEM_TYPE_VLAN || ...) {
                        ...
                }
        }

Clearly, that condition in the inner "if" is always "false". Before commit
ea0c22fd [2] outer "if" was:

if (eth_spec && eth_mask && eth_mask->type) { ...

Please clarify,  is there really an error?

[1]: http://git.dpdk.org/dpdk/tree/drivers/net/i40e/i40e_flow.c#n2448
[2]:
http://git.dpdk.org/dpdk/commit/drivers/net/i40e?id=3Dea0c22fd8227a3ac35079=
84ff766d66355a3651e

--=20
You are receiving this mail because:
You are the assignee for the bug.=