[Bug 942] i40e: condition in `i40e_flow_parse_fdir_pattern()` is always false

[Bug 942] i40e: condition in `i40e_flow_parse_fdir_pattern()` is always false

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=942

            Bug ID: 942
           Summary: i40e: condition in `i40e_flow_parse_fdir_pattern()` is
                    always false
           Product: DPDK
           Version: 21.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: Stepan.Repin@infotecs.ru
  Target Milestone: ---

`i40e_flow.c` contains the following code processing `RTE_FLOW_ITEM_TYPE_ETH`
in the function
`i40e_flow_parse_fdir_pattern()` [1]:

        if (eth_spec && eth_mask && next_type == RTE_FLOW_ITEM_TYPE_END) {
                ...
                if (next_type == RTE_FLOW_ITEM_TYPE_VLAN || ...) {
                        ...
                }
        }

Clearly, that condition in the inner "if" is always "false". Before commit
ea0c22fd [2] outer "if" was:

if (eth_spec && eth_mask && eth_mask->type) { ...

Please clarify,  is there really an error?

[1]: http://git.dpdk.org/dpdk/tree/drivers/net/i40e/i40e_flow.c#n2448
[2]:
http://git.dpdk.org/dpdk/commit/drivers/net/i40e?id=ea0c22fd8227a3ac3507984ff766d66355a3651e

-- 
You are receiving this mail because:
You are the assignee for the bug.

[DPDK/ethdev Bug 942] i40e: condition in `i40e_flow_parse_fdir_pattern()` is always false

[bugzilla]

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

https://bugs.dpdk.org/show_bug.cgi?id=942

dengkaiwen (kaiwenx.deng@intel.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |kaiwenx.deng@intel.com

--- Comment #2 from dengkaiwen (kaiwenx.deng@intel.com) ---
Close this ticket.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #2: Type: text/html, Size: 2757 bytes --]