From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [Bug 958] Most drivers are silently ignoring 'has_vlan' rte_flow match criteria
Date: Tue, 15 Mar 2022 20:01:57 +0000 [thread overview]
Message-ID: <bug-958-3@http.bugs.dpdk.org/> (raw)
https://bugs.dpdk.org/show_bug.cgi?id=958
Bug ID: 958
Summary: Most drivers are silently ignoring 'has_vlan' rte_flow
match criteria
Product: DPDK
Version: 21.11
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: major
Priority: Normal
Component: ethdev
Assignee: dev@dpdk.org
Reporter: i.maximets@ovn.org
Target Milestone: ---
VLAN presence attribute 'has_vlan' in the 'struct rte_flow_item_eth' was
introduced by commit:
09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN items")
However, AFAICT, to the date, only 2 drivers actually supports that attribute.
These are mlx5 and sfc.
All other drivers (i40e, bnxt, ...) are not checking 'has_vlan' at all.
Since the attribute is not checked by the drivers, it's not possible to
identify if the particular driver supports it or not. Driver will just
accept the structure in most cases and validation will pass.
Documentation at https://doc.dpdk.org/guides/nics/overview.html says that
most of the drivers supports 'eth' rte_flow item, but that is clearly
wrong, since they doesn't support 'has_vlan' flag. All of them, except
for mlx5 and sfc should be marked as partial support (P).
This problem makes the 'has_vlan' attribute practically unusable by any
application, e.g. OVS, which is not designed to work with a particular
driver, but needs to support a large variety of different hardware.
From the OVS perspective, we seem to need the 'has_vlan' functionality in
order to fix the vlan matching bug, but we can not use it, because that
will introduce a lot of issues with drivers that silently ignore this flow
attribute:
https://patchwork.ozlabs.org/project/openvswitch/list/?series=284866
On a side note, rte_flow_item_eth.{src, dst} was supposed to be removed in
21.11 release (according to the deprecation notice), but these fields are
still in the structure and most drivers are still using them.
--
You are receiving this mail because:
You are the assignee for the bug.
reply other threads:[~2022-03-15 20:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-958-3@http.bugs.dpdk.org/ \
--to=bugzilla@dpdk.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).