DPDK patches and discussions
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [Bug 975] Power DOWN of copper interface not working in e1000 driver
Date: Wed, 23 Mar 2022 13:51:41 +0000	[thread overview]
Message-ID: <bug-975-3@http.bugs.dpdk.org/> (raw)

https://bugs.dpdk.org/show_bug.cgi?id=975

            Bug ID: 975
           Summary: Power DOWN of copper interface not working in e1000
                    driver
           Product: DPDK
           Version: 22.03
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: tobias.karlsson@netscout.com
  Target Milestone: ---

A bug crept in via commit 44dddd14059f151f39f7e075b887decfc9a10f11

In function e1000_power_down_phy_copper_base()
  in file drivers/net/e1000/base/e1000_base.c

The following change is needed or the interface will not be brought down
properly:

-       if (phy->ops.check_reset_block(hw))
+       if (phy->ops.check_reset_block(hw) == E1000_SUCCESS)
                e1000_power_down_phy_copper(hw);

Please also update the comment above these code lines.

-- 
You are receiving this mail because:
You are the assignee for the bug.

                 reply	other threads:[~2022-03-23 13:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-975-3@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).