From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4FCBCA0503;
	Thu, 19 May 2022 10:33:09 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 3865B40150;
	Thu, 19 May 2022 10:33:09 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id E394A40140
 for <dev@dpdk.org>; Thu, 19 May 2022 10:33:07 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 7E26D8A;
 Thu, 19 May 2022 11:33:07 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 7E26D8A
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1652949187;
 bh=EmsoZW1+89PuvwuvhhDX9ZM3nKoTxmXTQ/RzSVkksFE=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=Gbe0JylBVHh20FK3uCzM3Tj6+vHoVutZnMBDo70lFbdxlZyxOyN0NMJe6c8EXY7ED
 NJnhkavOtfiygRoCcbu/jo4xXrIxTeOB9tRv4bnMXtULLbOVkJQFhAp7n8pjvQ18uO
 uJ2OxW6c0mLLkToPOORm/clxXfj1dKNa66IaJ7yQ=
Message-ID: <c0094d93-77d5-e55d-583a-a5873c589ced@oktetlabs.ru>
Date: Thu, 19 May 2022 11:33:07 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v6 4/5] ethdev: format module EEPROM for SFF-8472
Content-Language: en-US
To: Robin Zhang <robinx.zhang@intel.com>, dev@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>,
 Ferruh Yigit <ferruh.yigit@xilinx.com>
References: <20220426024349.1081666-1-robinx.zhang@intel.com>
 <20220511021442.811950-1-robinx.zhang@intel.com>
 <20220511021442.811950-5-robinx.zhang@intel.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20220511021442.811950-5-robinx.zhang@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 5/11/22 05:14, Robin Zhang wrote:
> This patch implements format module EEPROM information for
> SFF-8472 Rev 12.0
> 
> Signed-off-by: Robin Zhang <robinx.zhang@intel.com>

[snip]
> diff --git a/lib/ethdev/sff_8472.c b/lib/ethdev/sff_8472.c
> new file mode 100644
> index 0000000000..1bbabbde1a
> --- /dev/null
> +++ b/lib/ethdev/sff_8472.c
> @@ -0,0 +1,287 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2022 Intel Corporation
> + *
> + * Implements SFF-8472 optics diagnostics.
> + *
> + */
> +
> +#include <stdio.h>
> +#include <math.h>
> +#include <arpa/inet.h>

The patch still breaks Windows build because of the above
header [1] and [2]. Including mingw build.

[snip]

[1] http://mails.dpdk.org/archives/test-report/2022-May/279975.html
[2] http://mails.dpdk.org/archives/test-report/2022-May/279929.html