* [dpdk-dev] [PATCH] ethdev: remove unused struct forward declaration
@ 2018-03-16 11:14 Ferruh Yigit
2018-03-16 14:09 ` Shreyansh Jain
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2018-03-16 11:14 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Ferruh Yigit
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
lib/librte_ether/rte_ethdev.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index d58b0cb02..71c3d29a4 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -1117,8 +1117,6 @@ struct rte_eth_dcb_info {
#define RTE_ETH_QUEUE_STATE_STOPPED 0
#define RTE_ETH_QUEUE_STATE_STARTED 1
-struct rte_eth_dev;
-
#define RTE_ETH_ALL RTE_MAX_ETHPORTS
/* Macros to check for valid port */
--
2.13.6
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] ethdev: remove unused struct forward declaration
2018-03-16 11:14 [dpdk-dev] [PATCH] ethdev: remove unused struct forward declaration Ferruh Yigit
@ 2018-03-16 14:09 ` Shreyansh Jain
2018-03-16 14:29 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Shreyansh Jain @ 2018-03-16 14:09 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: Thomas Monjalon, dev
On Fri, Mar 16, 2018 at 4:44 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> lib/librte_ether/rte_ethdev.h | 2 --
> 1 file changed, 2 deletions(-)
>
With movement to rte_ethdev_core.h, this looks correct.
Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: remove unused struct forward declaration
2018-03-16 14:09 ` Shreyansh Jain
@ 2018-03-16 14:29 ` Ferruh Yigit
2018-03-27 18:35 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2018-03-16 14:29 UTC (permalink / raw)
To: Shreyansh Jain; +Cc: Thomas Monjalon, dev
On 3/16/2018 2:09 PM, Shreyansh Jain wrote:
> On Fri, Mar 16, 2018 at 4:44 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> lib/librte_ether/rte_ethdev.h | 2 --
>> 1 file changed, 2 deletions(-)
>>
>
> With movement to rte_ethdev_core.h, this looks correct.
Good idea to add:
Fixes: 331c447ad913 ("ethdev: separate internal structures into own header")
Cc: ferruh.yigit@intel.com
>
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] ethdev: remove unused struct forward declaration
2018-03-16 14:29 ` Ferruh Yigit
@ 2018-03-27 18:35 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2018-03-27 18:35 UTC (permalink / raw)
To: Shreyansh Jain; +Cc: Thomas Monjalon, dev
On 3/16/2018 2:29 PM, Ferruh Yigit wrote:
> On 3/16/2018 2:09 PM, Shreyansh Jain wrote:
>> On Fri, Mar 16, 2018 at 4:44 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>> ---
>>> lib/librte_ether/rte_ethdev.h | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>
>> With movement to rte_ethdev_core.h, this looks correct.
>
> Good idea to add:
>
> Fixes: 331c447ad913 ("ethdev: separate internal structures into own header")
> Cc: ferruh.yigit@intel.com
>
>>
>> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-27 18:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-16 11:14 [dpdk-dev] [PATCH] ethdev: remove unused struct forward declaration Ferruh Yigit
2018-03-16 14:09 ` Shreyansh Jain
2018-03-16 14:29 ` Ferruh Yigit
2018-03-27 18:35 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).