From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEB5FA00C3; Tue, 20 Sep 2022 16:56:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7294440DFB; Tue, 20 Sep 2022 16:56:24 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2047.outbound.protection.outlook.com [40.107.244.47]) by mails.dpdk.org (Postfix) with ESMTP id 3E5F74069B for ; Tue, 20 Sep 2022 16:56:23 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gapd9A3iJtBb9nSm+y4yKOKA7c6w/MgSAKh0hQVI0wysH+bKfP6Pgo6811wODmVquEb51jzDI9b0DHGW22Do1V6whh/TvA95n7ccQJvIuD5wRpO4QDawOzK/UkQy5nMK9EFN7cnDLx3m+A/fPyD73GagXj70+/cpWMUavz1gQ6B71/H6M2eY1/1CxDfBj9/FWtmVaW3Wjn4vwsO5yOMgz276zgzAo00s6rOwYdx8oo3Lap+utCAGTpwt99pUB780qCPEZxgkuqnwHLqQdoW4xpjWW2AzMNHxmupFMTfvU4YmwKgXtSWjOJNkNGDEG5FEbGT2A7RNlIbyVo9jmB1gFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a0yNJyouGMwTu010XD+hOQclT6VqjJCu0Jbg313X4FI=; b=cqB1XJB8EF5mEoFVks4QEtjKBwQcF4audreN6cPau/GpaXld1M0VpGdPsFd7VJA8F5JYq4IBo9/4mxyzc2c/WtS/yb7X0kLcuD+L3s8MUSziDj8MwYuxxZZFupxYohwDFqZ0xDixoNvFVoNk0FacodeSC3NI5FYTnla6EZEQYX0e+2Ok7LrELIVUSarwOdqNb0F4DoHWC9UghyftD1qWAa3gDRvBGTHRQiUvVftRKK6oY/00vDIylG+jKP2SGHHCbvQEgx209RJXJFH5INpmdCdPCbgFiI8kYYTYngU4Ac70KimMTxtMIOt2M8HiSfKn2zyxwt+pBfCQc4chjaRf8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=corigine.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a0yNJyouGMwTu010XD+hOQclT6VqjJCu0Jbg313X4FI=; b=qN5Ch3PJ2/qn5aT3aei6S/q04MSTruRsa7pOfE4KPuXu3xHs4heV7EuZR+PZm7wHRLsuqUkPrV38+CaHhrh8+pfWfinfV/p1yDL9XsFohVgJbdSdnNgwX+JfUGwQnAS6BbTJxFNqNftKes/EzcnJhsa/yED2DZ9qkLmeh3tvAtE= Received: from SA1P222CA0072.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:2c1::28) by CH2PR02MB6710.namprd02.prod.outlook.com (2603:10b6:610:7e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.21; Tue, 20 Sep 2022 14:56:20 +0000 Received: from SN1NAM02FT0003.eop-nam02.prod.protection.outlook.com (2603:10b6:806:2c1:cafe::75) by SA1P222CA0072.outlook.office365.com (2603:10b6:806:2c1::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 20 Sep 2022 14:56:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0003.mail.protection.outlook.com (10.97.4.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 14:56:20 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 20 Sep 2022 15:56:19 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Tue, 20 Sep 2022 15:56:18 +0100 Envelope-to: chaoyong.he@corigine.com, dev@dpdk.org, oss-drivers@corigine.com, niklas.soderlund@corigine.com Received: from [10.71.194.74] (port=60637) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oaefa-0003ri-KG; Tue, 20 Sep 2022 15:56:18 +0100 Message-ID: Date: Tue, 20 Sep 2022 15:56:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v9 00/12] preparation for the rte_flow offload of nfp PMD Content-Language: en-US To: Chaoyong He , CC: , References: <1663238669-12244-1-git-send-email-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <1663238669-12244-1-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1NAM02FT0003:EE_|CH2PR02MB6710:EE_ X-MS-Office365-Filtering-Correlation-Id: 88a2696a-24f8-41f7-080e-08da9b184757 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pilRnCf4UwEPCtyluS1M7ylz/Urnks9NsTK8AZV8kDcShpps/sDISJT7o85ZBrEdLPzlYjKMMC5ByAXaYBD+0GkNEHJPudv4jj1qkrwYqkd6xrpB2JFp0mMmHEEAn2dNaphBkgG6BlJ+zO/etN3nja5lpA3a7bGrLMUqn1t1HCSk79SEVKvmfJZ+Nrt53iDWSOOA1gSfr3WW0VXrbDjiSRcx1H+s8ILfH7xNc462NEd3WNE6x1GqGU6sdtXW6GUSt9MfmvuX0xw34vkoTJHKb84G9+pROlhRp9xC9gCJw4EYf0yAil2OtLsBDie95+XoRN6M3YqTAJTDGsIXGqipRbkp27sl8G4a7W8P6+rN3Bx2oG3r2KeJuPNrK7NMNkn7Ngtxo35ZnVN5DIf/Kbvio1eUB78duT2aDNUTQ4+0m6MKT7NxtLPZaSaS6yoOLHh7zyA4fv8OrV+zP2GjPSuIoi1PVrfursQrNQjgOWoeOs3tjzq6qSfFIvpGc/dEhGzB8OQSqn6sn3uNli0Hjk7b1K/KIZk5Eyu15pmo1wGyTyy073Z0rzlGxDgk7IzUy3Y31J23cHLNLTOd6xaHSqCSgQbz+4UY9tNccoHbQxBvtN2WMaq4HMzavE3L+gBX2azFqURjFkreC/Hc9BbtJSal9tbOrXn2h3cAehQooPuFHQ8i9SVPWVXz1dp+c+0Kw1f+dweJUhz0Xtp60ilEygFD5+GMkL5zWkBbmkbj/ujxl/AIrbYZY91AMcSv2/R2ZY1aXHeSmQ6o6Mn1erLEkc+y5AK73iNwFmIWVFKn5qz0AgNCNpcSyL+L+RFK/zy4NrE6/4iXFJJGo1ZVrCtYn9uwEg== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230022)(4636009)(396003)(376002)(136003)(346002)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(70206006)(31686004)(9786002)(44832011)(47076005)(5660300002)(2906002)(426003)(83380400001)(40460700003)(41300700001)(110136005)(316002)(186003)(82740400003)(36756003)(70586007)(2616005)(336012)(82310400005)(8936002)(7636003)(26005)(31696002)(53546011)(478600001)(36860700001)(356005)(54906003)(8676002)(4326008)(40480700001)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 14:56:20.2409 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88a2696a-24f8-41f7-080e-08da9b184757 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0003.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB6710 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/15/2022 11:44 AM, Chaoyong He wrote: > * Changes since v8 > - Update the nfp.rst > - Fix the 'app_hw' to 'app_fw' > - Remove the ovs compatible header file > - Remove the use of rte_eth_dev_configure()/rte_eth_rx_burst()/rte_eth_dev_start() API > > * Changes since v7 > - Adjust the logics to make sure not break the pci probe process > - Change 'app' to 'app_fw' in all logics to avoid confuse > - Fix problem about log level > > * Changes since v6 > - Fix the compile error > > * Changes since v5 > - Compare integer with 0 explicitly > - Change helper macro to function > - Implement the dummy functions > - Remove some unnecessary logics > > * Changes since v4 > - Remove the unneeded '__rte_unused' attribute > - Fixup a potential memory leak problem > > * Changes since v3 > - Add the 'Depends-on' tag > > * Changes since v2 > - Remove the use of rte_panic() > > * Changes since v1 > - Fix the compile error > > Depends-on: series-23707 ("Add support of NFP3800 chip and firmware with NFDk") > > Chaoyong He (12): > net/nfp: move app specific attributes to own struct > net/nfp: simplify initialization and remove dead code > net/nfp: move app specific init logic to own function > net/nfp: add initial flower firmware support > net/nfp: add flower PF setup logic > net/nfp: add flower PF related routines > net/nfp: add flower ctrl VNIC related logics > net/nfp: move common rxtx function for flower use > net/nfp: add flower ctrl VNIC rxtx logic > net/nfp: add flower representor framework > net/nfp: move rxtx function to header file > net/nfp: add flower PF rxtx logic > Hi Chaoyong, Patchset looks good, except from two issues we have discussed before, those issues are: * Creating a new ethdev just for driver-FW control communication * Application (OvS) specific code in the driver I commented them separately and cc'ed more folks, we can proceed when above are resolved. Thanks, ferruh