Re: [PATCH v2] vdpa/sfc: fix null dereference

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 1/29/22 19:07, Weiguo Li wrote:
> Fixes: b11961363b4a ("vdpa/sfc: support device configure and close")
> 
> Signed-off-by: Weiguo Li <liwg06@foxmail.com>
> ---
>   drivers/vdpa/sfc/sfc_vdpa_ops.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/vdpa/sfc/sfc_vdpa_ops.c b/drivers/vdpa/sfc/sfc_vdpa_ops.c
> index c4ce4474ef..b3d9b6cd56 100644
> --- a/drivers/vdpa/sfc/sfc_vdpa_ops.c
> +++ b/drivers/vdpa/sfc/sfc_vdpa_ops.c
> @@ -611,7 +611,7 @@ sfc_vdpa_dev_config(int vid)
>   
>   	ops_data = sfc_vdpa_get_data_by_dev(vdpa_dev);
>   	if (ops_data == NULL) {
> -		sfc_vdpa_err(ops_data->dev_handle,
> +		SFC_VDPA_GENERIC_LOG(ERR,
>   			     "invalid vDPA device : %p, vid : %d",
>   			     vdpa_dev, vid);
>   		return -1;
> @@ -666,7 +666,7 @@ sfc_vdpa_dev_close(int vid)
>   
>   	ops_data = sfc_vdpa_get_data_by_dev(vdpa_dev);
>   	if (ops_data == NULL) {
> -		sfc_vdpa_err(ops_data->dev_handle,
> +		SFC_VDPA_GENERIC_LOG(ERR,
>   			     "invalid vDPA device : %p, vid : %d",
>   			     vdpa_dev, vid);
>   		return -1;

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime