From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0065.outbound.protection.outlook.com [104.47.34.65]) by dpdk.org (Postfix) with ESMTP id 00F9B1B1C7 for ; Fri, 6 Oct 2017 14:59:26 +0200 (CEST) Received: from CY4PR03CA0079.namprd03.prod.outlook.com (10.171.242.148) by CO2PR03MB2358.namprd03.prod.outlook.com (10.166.93.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 6 Oct 2017 12:59:25 +0000 Received: from BY2FFO11OLC004.protection.gbl (2a01:111:f400:7c0c::167) by CY4PR03CA0079.outlook.office365.com (2603:10b6:910:4d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7 via Frontend Transport; Fri, 6 Oct 2017 12:59:25 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11OLC004.mail.protection.outlook.com (10.1.15.184) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Fri, 6 Oct 2017 12:59:23 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v96CxKnL030725; Fri, 6 Oct 2017 05:59:21 -0700 To: Thomas Monjalon CC: Hemant Agrawal , , References: <1505558149-28884-1-git-send-email-hemant.agrawal@nxp.com> <1505558149-28884-2-git-send-email-hemant.agrawal@nxp.com> <4808052.LEHOq8oruM@xps> From: Shreyansh Jain Message-ID: Date: Fri, 6 Oct 2017 18:41:35 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <4808052.LEHOq8oruM@xps> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131517683640591554; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7966004)(346002)(39380400002)(39860400002)(376002)(2980300002)(1109001)(1110001)(339900001)(377454003)(24454002)(43544003)(189002)(199003)(83506001)(2906002)(8676002)(230700001)(8656003)(8936002)(65806001)(229853002)(64126003)(65956001)(189998001)(97736004)(36756003)(68736007)(50986999)(104016004)(6916009)(85426001)(65826007)(2950100002)(4326008)(81156014)(86362001)(58126008)(54906003)(5660300001)(316002)(69596002)(33646002)(53936002)(6246003)(81166006)(498600001)(23676002)(47776003)(105606002)(76176999)(15650500001)(77096006)(50466002)(305945005)(31696002)(6666003)(31686004)(106466001)(54356999)(356003); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR03MB2358; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC004; 1:sPR9KQxcyDmtiA9jNbaSxxR6MTP1t8izv1AEYg6jnnaeHkqUyqTncsU4vnx5khG6SGQywfnoImDcQtXYLmyyVzqQaG3BPj4gsw3+qoes/MdOAtTWhHpqTBG8Ny5u38NO X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ec6f7328-32fa-4cf1-59d2-08d50cba1178 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:CO2PR03MB2358; X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2358; 3:Ct5BLdj3iclf/cxGiN3Ex2WAQtHTTx1ptbjSSiSil8RFLEY9yejR/bh1U54LHaJX11y3Z80hBGavXkKqy5f7D6h+qo1UtoGC6cn9yshXTahUJVx5KMxM14g3mJwkwyujmue01Kr4ckexBlCLa1t7qzULNcRtL7HeQD5fP0GQt990dUC64NXvTY+HMo96kSAQ3FFIYBcJkWrD2C5HSYfZZ+gH31HJaeDEPxfU+mwfZbqDlCIYsl/WCtSCZFcYrjtsCqOnBHomMr53d3D4q+URF3F+GZZ+t3rtafCO4Kd0oD91jgycSCS1iplvba5T6du69k+T/kdiS8PbhZgTGcx2cL04VOTE5NKdKxILrgD7a8c=; 25:K1/kJD94Gc2jb+VNti6wRdDKqZ+rZeuMfgSpUyNXvo0Wj5rQuGFhtghCBWZqZ7YDgDbYgdaRFcsOzUEd0YJDsSq3D7qkBynZhi2r4WifPuGgX1w58Z23/QZedlZmW4/bXCM2UtkSHounETvHsnPfxWDeevph2+opMSwd739yySAmD4f90OWJT+Etw8WjPY9sWUbfZt9XK6DUSpSVtf+UArB8Ho1BNlTffcFNi60P28ZbxLrYwlgUF0mu4mjT7uvbJ7tSWg8kf651p8g2vzGWcWsJfzcsYF+rsGhSpqgPm18Wev3vDqXHUnM6oMrsEefux/3K5oEHJ1LjTPqqmCc3Ng== X-MS-TrafficTypeDiagnostic: CO2PR03MB2358: X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2358; 31:WOi+VTaqKMiD/Y+1rdlgCie8Z8QFwZpNXDuQXW6cw/3XuR2nAsO0NlL4LjhnDxaNPeHUQZcnkln3pwRCKKYI80JixZTmh0B3NZ3SgCkItLVUYNdnJs3m+wsceeMEqvS7nn2rGCY906k3hkclC7vBGf7Xrn7TNxGWWjH7s3sjXDBVhUn2SkMBlv7hJC7lOkniIpWX3TH1oyFFuya34e7wriuivDlbzbH2EH0UmoWyN5c=; 4:6hciliXERLHidYXOJEyQK/94I+9g0PV/DnAoYuqFnaPrtntEz1mbcu1sLReI+bzFvI8+hYf5zK9jHImf1IkBWwllAJ2KDkbH3KJuhXVXJ44pzK9CoaHJqmIviHJFemwhEh4nYImlF7bwF7/SGOTtVJBuOHKzBeb3In5GlJnXHairxkDnP6QWcc0fMMMUOeCJrEQ95ctDzEjGIFfa4sDEST5HazYfs9dvVpt+dKLRTbJO69hthKOiB7MQOZiKnCXkuI9cO9WJ+AtkdeC4eUb4nBL803ctMU9TkuOu8sGUXJQ= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6096035)(20161123556025)(20161123559100)(20161123565025)(20161123563025)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(20161123561025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CO2PR03MB2358; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CO2PR03MB2358; X-Forefront-PRVS: 0452022BE1 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDTzJQUjAzTUIyMzU4OzIzOmQxVEV1YUs2c3RSb2J6b1lTN0dvTGNkZFZ2?= =?utf-8?B?aVFzUlVVWjdvZytsYjBSdVVjOS9CYThkYkJjMzRKZllWb1lKbW55UmRiZ2p4?= =?utf-8?B?OEJCT3ZYT0dBOU5VRDgvVXFvRFp0NEpGYVFzaEpUSU54VHZ5ZTVEakhKTzMy?= =?utf-8?B?dXpjYzJGcVVOSFk5a1hjZmZhSFduT1dybUVRekpUTEI2Z2luNEdXL3ZqZUFS?= =?utf-8?B?TVhFdWVvV2lBaFA1SHZHWDRoREl6ZXgvQXRJWFArVFRkRnZhZVN3UzFvK1Mz?= =?utf-8?B?dHl1WW0vbnBlM0xwSFJnNUdPREV1cGVpNW9KYitSU0JXaWRrTmJBS1FtUXJo?= =?utf-8?B?RXNNVDhYaXlpcVd3akEyR2pZUDk5YklkUWJPSkhNeVM1ZjJpYjV1OC9iZFVB?= =?utf-8?B?WWNWU3pIQ1hFQWQ4M1hzT3RhWFJ6Y25rV1ljRVVPMjZYWGUrNVpERnZjcE1C?= =?utf-8?B?bU5BUFBXSnJlL2dleGRyd2c3MzVpK2VVYm1KOXhwdys2VVdnUGFSYjc2cngv?= =?utf-8?B?UjJ6TVpkenJreWdGZHNmZVRPUGNMSHJsOUpDMXQ3MGdkelNIVVppUWpEUGdP?= =?utf-8?B?RHFFa2loYk9yaGZObERuZFRyVGVtKzN1Rkl2U2NSbm8rVTFoSWQrem1HUmoz?= =?utf-8?B?L2FacklkeVBwanlSeGVjOU85a1hCZnY3dVpVcWZ5RnMzemxlWGhJcGFCc2pm?= =?utf-8?B?enN1YWZZcHgrWXlkd0pMc05nd2xOTzFGT3pQeXhqUDQrWU5Tdm9LU3JHSnB4?= =?utf-8?B?ZDdFZ3ViQzAvb3JHWlNkejByYzZSdjVMY09PQTBRVVBGRVUvWWYyVXFLeHVB?= =?utf-8?B?YnQxU2J4ZWY2a2hXVG5YS2pSZ3BBODBlbUVzWnhMTUsyZW9EK09ERlZaODUy?= =?utf-8?B?L1FSZmNGZ1E1ZnBYbmdBeXBqV2xvanM5bDdON3Y4TFIyT0FNODhBVm1ERVhC?= =?utf-8?B?TGk3R2hwbXdKYmM4UzAzWEpSYmw3aDU1QUk4amNBZmRBMTJIL3R2RXZsdEVr?= =?utf-8?B?NjN6OVJYN1RmNVBBSmFubHlETXQwaDhNL3J1cVpzbU4yYXVXZ2VuWHZGL1Np?= =?utf-8?B?aWRRRlBRL244cUhmVmNpTngvTXNHOC9TUG1PT1l6MDJqczQ3aDhhdkFGUkw4?= =?utf-8?B?ZzUvSW0yL1RZdFRnMkx4SDVJaXdTK3RaY3h6VUxoWVpKaU5NdGY3b3RzTGtj?= =?utf-8?B?amJPZmRSMmdIdUNKRzZXUlpFc0Y1YjBLaHBnOGZtc0lvYzl1cWloY0ZLV2hl?= =?utf-8?B?Q0txWldBRDBSQUhNNGtDOHRUYWdjcWczVmZGY1JQbnpFcm5Ma2k0TWI3V0Uw?= =?utf-8?B?RC93bkc0R1dGYXhScmtheVV3QVR3dWw3TE04SitmQlo1eUZ3cnVVaDFHT1A2?= =?utf-8?B?a2kwaGR1RFVkakVEZHA5Vm9WaDRnSzBqUHYrUHR6WG9RcitoOFcwL0ZTQ1RO?= =?utf-8?B?cnduM1hHMkhVTmZNZHdkOWJrc0Z4QW1CRTBZVWtyM1RESHRrald6OW1JMVFX?= =?utf-8?B?bVFoWU0vczhVZUl5VU1pYStQMGowR2gxbXlaMmtjczlTTzUrOUhndHNMSmlZ?= =?utf-8?B?UC8zeTZaR0EwMWZPalFCZzNoUjU1VzNmR0xJM3ZyK3NqRGFWREl4MVJ3c3lF?= =?utf-8?B?K3dsSUt6Wnd1cy9xVklxWDUxaC8vSm1JR1dFQkNtTE9wQk0rY3BRcWEycVVx?= =?utf-8?B?WUVRVmxwLzNmd0g4N3hST1U4akNaRmN1a3Ivd001RXBBbktMZTJ5WEQ5QS9V?= =?utf-8?B?d2NoMVptZWJwaForalZxcmJNTVpiaTZqOHFkZysrVVFSaGFjS0QxOFhiK212?= =?utf-8?B?Z3psTEdnS0NYOExuejhWbUZvRVpFN2FCdDM0ZEtON2hZN3RLVi9UZnNlMndJ?= =?utf-8?B?Yy9VZkMxRHg1S1RhOGJTY0o4bHJ6UnRXMUZyWjRRbnMwUmM0UGlpYVZXTUNn?= =?utf-8?B?aFdNaC9DakVBMHhTNTlBYnRQNVp6MytERTBpb0d2b0VPTzRtcGFYM0d1RWlj?= =?utf-8?Q?jHYNMw?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2358; 6:6xzsYPSMeJiziqj0ZGSJuCeKPNxm4Z8nw+j8WghfNVzXJFdWtVVE5o2SKQ3AZ97lksloOuJzt7iOhsXS4lIbAMsiToyGhXsAv/c5/Yy4ouNtWBjw4EWtYIaz77mKI5WJa3RVWJoXptAT8HTqSoSHXfmHjmBVfohnkvEtYxy5up1TzMuoMd0YbajHbP7BzkpoTokAnIwlS7N41rkcfjwmwd/8MeGrFDjF108GVINlPWfK/EI1L0LaHkS+DwlUblc4FjsOUJMPjFxDarHnT10fy7ThLj6tAmYF5Epw7qtUqN9yrKzoaOeYvPa/yw89V3E09FkvGPoIb6iZw9u0mtgzZw==; 5:qavXcBwut34kTRjK1RSNOZAkxzcdI5aApjcUzy4/w9QRp5viu0RM8ulpZVe5MYudOIaxofgIpSgmFvz1s7PnWzbpbDvh7hb63AL4Byc8C+ANB8ymRO2etEvAaP4J4QY+t68yjDAK63SWAWQ/AQqYpg==; 24:QUXTPU/zbdqdwCzW775zFsRPHWPAO+wOWT6HNTZUG4GEU+QeUl9/egS6ioyx5EqnfFp8jonp53NTx8OuN/+IaJwjHymxi9Ja4HuJj4v/G1Q=; 7:2pktJy11UQ9LYN2thZlmy3biTP4podvxK95zSSbrXOMzS5V2rtHPBzyxy7fAJfkzFoDszcVzxn8XQnOhYTSTZtb3Xee7nKWq1P//gfHYnIITPEZoc5wSmJr20sEjl2w2rA/0BXc4H/pdFiiHe95HoNCjIwZL2TLqNTV1mDNwexxazTuoDjKiZxL833Fm0UP/fRf2UoVeDK/2vAqgwnNnw+789IgiBzMCKe3sbvYjczY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2017 12:59:23.8095 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2358 Subject: Re: [dpdk-dev] [PATCH] bus/fslmc: update MC to 10.3.x X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 12:59:27 -0000 Hello Thomas, On Friday 06 October 2017 05:04 AM, Thomas Monjalon wrote: >> Signed-off-by: Shreyansh Jain >> Signed-off-by: Hemant Agrawal > > This is a huge patch without any comment! > It will be hard to find bugs in it when debugging in future. > And it will be also pointless to reference it in future fixes. > From a quality point of view, it is bad. Well, this patch is actually changing the lowest glue code for DPAA2. I did split into multiple patches (component wise) but it didn't make much sense as they were still un-reviewable. I merged them back again. Ironically, this series was actually to make code easier to read - improving overall glue code quality. Improving comments and variable naming, removing large macros - with minimal functional impact. > > As it is touching only to dpaa2 stuff, it is accepted. > I do not want to be the one digging in it. Fair enough. I am not expecting that someone will review. It is internal stuff to DPAA2 and not something which can be reviewed without context. > Please avoid such patch in future. This is somewhere I have doubt. The core model of DPAA2/DPAA1 drivers is hardware interfacing code which is large in size. This layer tends to change when newer internal versions are released or some update is made (bug fixes). We don't send changes out very frequently - that is why they gather over a longer period. Keeping them in original state (multiple patches) only ends up spoiling DPDK commit history. Being a single commit, I think bisects would be easier in the sense that a bisect would either contain or not contain these internal changes. But, I will definitely take care to make them as commented/documented as much as possible in future. (Though, I do take care of splitting any patch which touches the DPDK API layer into logical splits as that is reflected in commit history.) > > Applied > Thank a lot.