* [PATCH] app/testpmd: fix unpassed RSS algorithm
@ 2024-03-15 3:00 Jie Hai
2024-03-15 11:17 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Jie Hai @ 2024-03-15 3:00 UTC (permalink / raw)
To: dev, Aman Singh, Yuying Zhang, Ferruh Yigit, Huisong Li
Cc: fengchengwen, haijie1
The RSS algorithm from user is parased but not passed to the
rte_eth_dev_rss_hash_update() API as we wanted, this patch
fixes it.
Fixes: 3da59f30a23f ("app/testpmd: set RSS hash algorithm")
Cc: stable@dpdk.org
Signed-off-by: Jie Hai <haijie1@huawei.com>
---
app/test-pmd/cmdline.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f521a1fe9e8a..b7759e38a871 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -2319,6 +2319,7 @@ cmd_config_rss_hash_algo_parsed(void *parsed_result,
return;
}
+ rss_conf.algorithm = algorithm;
ret = rte_eth_dev_rss_hash_update(res->port_id, &rss_conf);
if (ret != 0) {
fprintf(stderr, "failed to set port %u RSS hash algorithm\n",
--
2.30.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] app/testpmd: fix unpassed RSS algorithm
2024-03-15 3:00 [PATCH] app/testpmd: fix unpassed RSS algorithm Jie Hai
@ 2024-03-15 11:17 ` Ferruh Yigit
2024-03-19 2:29 ` Jie Hai
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2024-03-15 11:17 UTC (permalink / raw)
To: Jie Hai, dev, Aman Singh, Yuying Zhang, Huisong Li; +Cc: fengchengwen
On 3/15/2024 3:00 AM, Jie Hai wrote:
> The RSS algorithm from user is parased but not passed to the
> rte_eth_dev_rss_hash_update() API as we wanted, this patch
> fixes it.
>
> Fixes: 3da59f30a23f ("app/testpmd: set RSS hash algorithm")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jie Hai <haijie1@huawei.com>
>
Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
Sorry to see we missed something this simple, wasn't this tested when
command is added?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] app/testpmd: fix unpassed RSS algorithm
2024-03-15 11:17 ` Ferruh Yigit
@ 2024-03-19 2:29 ` Jie Hai
0 siblings, 0 replies; 3+ messages in thread
From: Jie Hai @ 2024-03-19 2:29 UTC (permalink / raw)
To: Ferruh Yigit, dev, Aman Singh, Yuying Zhang, Huisong Li; +Cc: fengchengwen
On 2024/3/15 19:17, Ferruh Yigit wrote:
> On 3/15/2024 3:00 AM, Jie Hai wrote:
>> The RSS algorithm from user is parased but not passed to the
>> rte_eth_dev_rss_hash_update() API as we wanted, this patch
>> fixes it.
>>
>> Fixes: 3da59f30a23f ("app/testpmd: set RSS hash algorithm")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Jie Hai <haijie1@huawei.com>
>>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
>
> Applied to dpdk-next-net/main, thanks.
>
>
> Sorry to see we missed something this simple, wasn't this tested when
> command is added?
>
> .
I'm sorry for my mistake.
After the first round of functional tests passed,
I didn't double check it carefully after the second round of changes.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-19 2:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-15 3:00 [PATCH] app/testpmd: fix unpassed RSS algorithm Jie Hai
2024-03-15 11:17 ` Ferruh Yigit
2024-03-19 2:29 ` Jie Hai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).