From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5AF06A0A02; Wed, 13 Jan 2021 19:46:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33A4E140D38; Wed, 13 Jan 2021 19:46:44 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id AF447140D1E for ; Wed, 13 Jan 2021 19:46:40 +0100 (CET) IronPort-SDR: JjSRaWAbTBrH0sl8mnBgNw8yesO87G+jFgLBhoi78N+CBdFYqiyNmSkiFMne8NtRFCFT6zLrSE lFZ1/RjzCk8A== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="263043429" X-IronPort-AV: E=Sophos;i="5.79,344,1602572400"; d="scan'208";a="263043429" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 10:46:39 -0800 IronPort-SDR: 8uNImdfQu9WGKHWAdQ1d/m4b/xSU26g7dfHsgPK1qT4eDaHj0y7CCmKpJ9HCYSFoe6p5HR7xJP qhgUPPozn+sA== X-IronPort-AV: E=Sophos;i="5.79,344,1602572400"; d="scan'208";a="424665865" Received: from vmedvedk-mobl.ger.corp.intel.com (HELO [10.252.6.92]) ([10.252.6.92]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 10:46:37 -0800 To: Ruifeng Wang Cc: dev@dpdk.org, nd@arm.com, jerinj@marvell.com, drc@linux.vnet.ibm.com, honnappa.nagarahalli@arm.com References: <20210108082127.1061538-1-ruifeng.wang@arm.com> From: "Medvedkin, Vladimir" Message-ID: Date: Wed, 13 Jan 2021 18:46:34 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20210108082127.1061538-1-ruifeng.wang@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/4] lpm lookupx4 fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ruifeng, LGTM, Thanks! On 08/01/2021 08:21, Ruifeng Wang wrote: > This series fixed bug in lpm4 vector lookup implementations. > When more than 256 tbl8 groups are created, lookupx4 could > retrieve next hop data from wrong group. > The bug is there since next_hop field was expanded from > 8-bit to 24-bit, and inherited by other implementations. > > Also updated test case to improve coverage to detect such > failure. > > Ruifeng Wang (4): > lpm: fix vector lookup for Arm > lpm: fix vector lookup for x86 > lpm: fix vector lookup for ppc64 > test/lpm: improve coverage on tbl8 > > app/test/test_lpm.c | 22 ++++++++++++++-------- > lib/librte_lpm/rte_lpm_altivec.h | 8 ++++---- > lib/librte_lpm/rte_lpm_neon.h | 8 ++++---- > lib/librte_lpm/rte_lpm_sse.h | 8 ++++---- > 4 files changed, 26 insertions(+), 20 deletions(-) > Acked-by: Vladimir Medvedkin -- Regards, Vladimir