From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jasvinder Singh <jasvinder.singh@intel.com>, dev@dpdk.org
Cc: cristian.dumitrescu@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/softnic: fix undefined dev info fields
Date: Wed, 21 Nov 2018 15:28:41 +0000 [thread overview]
Message-ID: <c03c8cce-0793-fae1-9027-31a2c55d15ad@intel.com> (raw)
In-Reply-To: <7320c1c9-f81b-4316-798b-318bed80cf22@intel.com>
On 11/20/2018 10:35 PM, Ferruh Yigit wrote:
> On 11/20/2018 1:00 PM, Jasvinder Singh wrote:
>> The memcpy operation overwrites the device info fields set
>> by ethdev API and leaves the device field undefined.
>> Thus, replaces memcpy by only updating the required fields
>> at the driver layer.
>>
>> error log: testpmd> show port info 1
>>
>> **** Infos for port 1 ****
>> MAC address: 00:00:00:00:00:00
>> Device name: net_softnic0
>>
>> Segmentation fault.
>> port_infos_display (port_id=1) at /dpdk/app/test-pmd/config.c:418
>> if (dev_info.device->devargs && dev_info.device->devargs->args)
>>
>> Fixes: cc6d421574fe ("net/softnic: add softnic PMD")
>>
>> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2018-11-21 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 13:00 Jasvinder Singh
2018-11-20 22:35 ` Ferruh Yigit
2018-11-21 15:28 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c03c8cce-0793-fae1-9027-31a2c55d15ad@intel.com \
--to=ferruh.yigit@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).