From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vido@cesnet.cz>
Received: from office2.cesnet.cz (office2.cesnet.cz [195.113.144.244])
 by dpdk.org (Postfix) with ESMTP id 4858E911D
 for <dev@dpdk.org>; Wed, 31 May 2017 10:32:03 +0200 (CEST)
Received: from [IPv6:2001:67c:1220:80c:f8f4:f055:211e:fe80] (unknown
 [IPv6:2001:67c:1220:80c:f8f4:f055:211e:fe80])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by office2.cesnet.cz (Postfix) with ESMTPSA id 67C3E20008;
 Wed, 31 May 2017 10:32:02 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cesnet.cz;
 s=office2; t=1496219522;
 bh=dC9nSo4pgTQcelBlVDiWrZ5tLcEQUHMKHl+P1HYeXb4=;
 h=Subject:To:References:Cc:From:Date:In-Reply-To;
 b=cUtxYZq8Edph2RQ1otAfqz176fS6gb7G37n3wbGmfsuKe1J8hUcoXKitYUOaipkxM
 7vtllIzbSyMVCPihZ2ZKYZhyi4M1gzVKFqBM1tce33AhF4hNaarjHvz545AzW6Lk5d
 mBQxkTyWU7AIcgf9FSSM0Po44BpJETV9n7fHOJIE=
To: Ferruh Yigit <ferruh.yigit@intel.com>
References: <1495821956-5050-1-git-send-email-vido@cesnet.cz>
 <b89a6f4e-29e4-8594-fa99-ba53f7cc7531@intel.com>
Cc: dev@dpdk.org
From: Matej Vido <vido@cesnet.cz>
Message-ID: <c0646fab-99f9-654b-f5f1-564e9df00de8@cesnet.cz>
Date: Wed, 31 May 2017 10:32:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <b89a6f4e-29e4-8594-fa99-ba53f7cc7531@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH 1/5] net/szedata2: refactor ibuf and obuf
	names
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 31 May 2017 08:32:03 -0000

On 29.05.2017 14:40, Ferruh Yigit wrote:
> On 5/26/2017 7:05 PM, Matej Vido wrote:
>> Signed-off-by: Matej Vido <vido@cesnet.cz>
> Hi Matej,
>
> Overall patchset looks good to me, but can you please provide a little
> more information in commit logs, please check comments on patches.
>
> For this patch, it seems refactor naming is removing "cgmii", what is
> the reason of this, is cgmii no more true or adding different interface?
>
> Thanks,
> ferruh
Hi Ferruh,

ok, I will address the comments in v2.

"cgmii" was too specific. There can be different ibuf/obuf modules in 
different firmwares. But the address space definition is the same for 
all ibuf/obuf modules in all firmwares so this patch makes the name 
general (and also shorter).

Regards,
Matej
>
>> ---
>>   drivers/net/szedata2/rte_eth_szedata2.c |   80 +++++++++++++++---------------
>>   drivers/net/szedata2/rte_eth_szedata2.h |   48 +++++++++---------
>>   2 files changed, 64 insertions(+), 64 deletions(-)
> <...>