From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6136FA49 for ; Fri, 14 Sep 2018 18:21:02 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Sep 2018 09:21:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,373,1531810800"; d="scan'208";a="70883954" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.18.151]) ([10.252.18.151]) by fmsmga008.fm.intel.com with ESMTP; 14 Sep 2018 09:21:00 -0700 To: Andrzej Ostruszka , dev@dpdk.org Cc: mw@semihalf.com, zr@semihalf.com, tdu@semihalf.com, nsamsono@marvell.com References: <1535718368-15803-1-git-send-email-amo@semihalf.com> <1535720386-18775-1-git-send-email-amo@semihalf.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Fri, 14 Sep 2018 17:20:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1535720386-18775-1-git-send-email-amo@semihalf.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 0/8] Add Marvell NETA PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Sep 2018 16:21:02 -0000 On 8/31/2018 1:59 PM, Andrzej Ostruszka wrote: > This patch series introduces new PMD for Marvell NETA adapters (MVNETA). > See the documentation for more info. > > It is split for easier reviewing. > > v3: > No changes against v2, just resubmitting again to have clean patch > set after my faulty format-patch. My apologies for the noise. > > v2: > * fixed couple of checkpatch warnings > * removed '\n' from MVNETA_LOG invocations (appended by the macro) > * removed unused MVNETA_MUSDK_DMA_MEMSIZE define > * changed one printf into MVNETA_LOG > * removed __func__ from one MVNETA_LOG invocation (inserted > automatically by the macro) > * minor grammar/spelling correction in comments > * removed license text from file with SPDX tag (mvneta.rst) > * removed misleading part of comment for mvneta_shadow_txq > * changed authorship of the patches to the original author > > Natalie Samsonov (1): > net/mvneta: add reset statistics callback > > Zyta Szpak (7): > net/mvneta: add neta PMD skeleton > net/mvneta: add Rx/Tx support > net/mvneta: support for setting of MTU > net/mvneta: add link update > net/mvneta: support for promiscuous > net/mvneta: add MAC filtering > net/mvneta: add support for basic stats Hi Andrzej, Patchset is mostly looks good to me, there is no major issue but I have commented on some minor issues. Can you also set a web page patch to add new hardware to supported hw list: http://core.dpdk.org/supported/ https://git.dpdk.org/tools/dpdk-web/