From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rere.qmqm.pl (rere.qmqm.pl [84.10.57.10]) by dpdk.org (Postfix) with ESMTP id 456E32BCF for ; Wed, 14 Dec 2016 18:23:41 +0100 (CET) Received: by rere.qmqm.pl (Postfix, from userid 1000) id E03526082; Wed, 14 Dec 2016 18:23:40 +0100 (CET) Message-Id: From: =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit To: dev@dpdk.org Cc: "Ananyev, Konstantin" In-Reply-To: References: Date: Wed, 14 Dec 2016 18:23:40 +0100 (CET) Subject: [dpdk-dev] [PATCH] acl: remove invalid test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Dec 2016 17:23:41 -0000 rte_acl_add_rules() has no way of checking rule size. This was hidden because the test effectively checked that adding a rule with userdata == 0 failed. Signed-off-by: Michał Mirosław --- app/test/test_acl.c | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/app/test/test_acl.c b/app/test/test_acl.c index 28955f0..be744ec 100644 --- a/app/test/test_acl.c +++ b/app/test/test_acl.c @@ -1515,26 +1515,6 @@ test_invalid_parameters(void) /* free ACL context */ rte_acl_free(acx); - /* set wrong rule_size so that adding any rules would fail */ - param.rule_size = RTE_ACL_IPV4VLAN_RULE_SZ + 4; - acx = rte_acl_create(¶m); - if (acx == NULL) { - printf("Line %i: ACL context creation failed!\n", __LINE__); - return -1; - } - - /* try adding a rule with size different from context rule_size */ - result = rte_acl_ipv4vlan_add_rules(acx, &rule, 1); - if (result == 0) { - printf("Line %i: Adding an invalid sized rule " - "should have failed!\n", __LINE__); - rte_acl_free(acx); - return -1; - } - - /* free ACL context */ - rte_acl_free(acx); - /** * rte_acl_ipv4vlan_build -- 2.10.2