From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EBE941CEC; Mon, 20 Feb 2023 15:02:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E86B743056; Mon, 20 Feb 2023 15:02:47 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2069.outbound.protection.outlook.com [40.107.101.69]) by mails.dpdk.org (Postfix) with ESMTP id 1303540395; Mon, 20 Feb 2023 15:02:47 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RkyycS4H/rbyf3h4gXD8JblXlKy+H8fig4JR3ohyXrAmJAsrUnDBEtASxd4UeFA3Gzaks6LGyK+JdXMOhU1170FHUabznRlfS7pn7hshc2jci1A5l1x/gWeXhHJ2rc2XGCUAYbwR4Z5WLtldd/K7RilhG8JFfWbnk1U0K9pBemasUBXiTgZz1AmwxX9n01tJLpjipXRUH9GFSoGFmeAiglkjSg0vQS+IbiEI4tcxABL6581AdTlYsg9o1E4KQYCJ5OHO+JYQ3XFewHfbffGWsKQjNrIPwHG/iMILYkjXeFA4SaaMLMzf2CjeadXOGt6tD7yaE8AItZNiwalHUvB6vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tu/rplU1GAxJDVo0KomkimKX/HQWg2RKORXD/NJ4Brw=; b=KWonNgmLZp3tp0qeaAXpNBJmb0nDchMfmpIfOLQYtAvx1kX3x7TH4rmnQHGfwMwmKB7NiAdyGAIBCUhBHmXTaWrMqpFwd7TcXwPC124rJxVsZwjtUU0npp9ANf7AphFhbrm3LhChcSfp5kPxoDBoipfB9r/j7tv40EmNiaqp32GSYstqtx/23C1EOdLgao1E3oNEC7VX92hdCtIOjs0PiYIHtwbkbihjNAX7AA4F8UMf4wwzPOej5ujDgRxwDVAmxXgsU9VRQetCg3jgKOFx51StaedfJb5UjGGt5evncDMK8XGBuRzbPqt9GywvdV6Tr9r0ONTpVira4jUtb3OpQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tu/rplU1GAxJDVo0KomkimKX/HQWg2RKORXD/NJ4Brw=; b=2ata5l/waa+8a5taPHe+IdYbvSpkY8p9rnJU90tLCGp9aOC0SVNLd36ZJHqFKi0MmiHJg6dp+F0Ny4n+Vu7d9qQ6xfj87ND1NPphZ1g6hCFd9oszUqsyI1LbHBii5Srfu6iqFkQTLEc3KR7KbrSvBlOJcVTTOOFBcPPdX7scJHA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA1PR12MB8744.namprd12.prod.outlook.com (2603:10b6:806:38c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.20; Mon, 20 Feb 2023 14:02:44 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%8]) with mapi id 15.20.6111.020; Mon, 20 Feb 2023 14:02:44 +0000 Message-ID: Date: Mon, 20 Feb 2023 14:02:38 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2] net/nfp: fix 48-bit DMA address support for NFDk Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Peng Zhang , jin.liu@corigine.com, stable@dpdk.org References: <20230208091544.22122-1-chaoyong.he@corigine.com> <20230220090254.10641-1-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <20230220090254.10641-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0166.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18a::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA1PR12MB8744:EE_ X-MS-Office365-Filtering-Correlation-Id: a39d3ffb-1562-4d50-a78c-08db134b2313 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hx9iV33hzV9DgreLghjrzrv2bC1e4mIknPtW0RV68QRFLk7x1cI8sIwvo1fQbPQeVNLrPiKf+D1jS7JTSQlJ/7KOshQbPhS6nVfhzK9BOy4hLVCZJs230sDduWNTUSe/n3SsXLG4IfZcAG5lc7+LzMtz+swcrox+x0F5O3dUgL3PS0We8MQYrMkNlmdPjPXlD3RRmSYdzIKCybpd2J/pc1t5BFQrBC526iFpyh80RotBSz6bw8+myy5+GnNTXNZQ5heg0ruMWBw9UcMVReBiBNzGS/zSobpTJHYRXkC8VhUr1BbpA/16u73npRCpzsGlaa5IfvbNXXFlxeYc/ldhmPSGbEyXkw0dNatlt+tKu20fY9KO8ILgyr3pEpfEP+YY5dgmeI+QxsUM1CUkfnZHqJ4bd1A36fF6Jb1qKSgSolqrrTgxfzALeG9s5xcm+k2eoRNJm/6zJqdew3X3AtXNDpFMlVn5hgFYoAt1++4CY2zmE3G4dzFMj1ziS6XBdwVh75hWXzjpHvaBxkPvx2suaa7Un05iSA/RtSxEeSeKnxbOtzp7m4CzCpYIZLJP3nD16z7ALWqpmp6mQP1u8hrGRZzG24sGUfvFmNmQRq7lCW7cGGxW9KdXseEqgCJkk6JwsqCzlsc6YZJ0BjoxyX8rWAhn2bS7yRIrM/jjX49qT7Xk51B5301t8cgybYRyZZlfT+06yLKOeoD98YinR32ek+lYeAen/vF+AmVFr3wS8zU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(396003)(136003)(346002)(39860400002)(376002)(451199018)(2906002)(38100700002)(186003)(6512007)(26005)(41300700001)(6666004)(44832011)(6506007)(31686004)(53546011)(2616005)(5660300002)(8936002)(316002)(6486002)(86362001)(8676002)(66476007)(66556008)(66946007)(4326008)(31696002)(478600001)(66574015)(36756003)(83380400001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUxxSnd2ck1JdnUwaEJ0bWNrd0NlZmRWM0h2aG5wQlhPL1RHTUhldlorMXVh?= =?utf-8?B?OFB6aHZZVEVjS3M2QXM1eW9tQkZDeHgvajVlcitvNnpBYnNWbExYMXJsWkNj?= =?utf-8?B?blRNUlZneWNVUXE0YXhyT2RaeEJ0OGdBOXVJWWs5K0R0dkd1Z09SZkN6L3V0?= =?utf-8?B?RjdIbEsyaTh5MHQ2dmlBYklPR2RHQmlUV1VnTUN0em4yUEFROUltQktCTVV0?= =?utf-8?B?R2RKMU5GR0J3NTNPNHY1RVpnYktrV1RlMENWdDJ3cm12MlNTM1B6SHpnWU5X?= =?utf-8?B?UFZXSEs4bHBTc3Urd2VTZHQ5RHRWaDdxMUd6eXVwQlFFeFBXTHVYTUtiMEVz?= =?utf-8?B?NTZLYWpLTzZ0UWtZSldKUk9ta3JyOWpLUUt1K3ZBdVR5djg2QmlQRTl5YUJ4?= =?utf-8?B?bDA3VnArWjJEVWNRd0g3TzRuNlFvc0VNSFhKd0F2TUlBdHZLWCtJMkhWS3ht?= =?utf-8?B?eVQwSlJ0Wk1CK1JJdDMyakVrM0w5cll4NDA5RlVKcExqa3BqMi9NZnkwd3Zo?= =?utf-8?B?eVBha2phbTlIMDJ2QTMva1lLUTdiRmZyOUpaRUsvQjRCVWRLRmJ5eWd5b3Ny?= =?utf-8?B?UmdEdWdjLzJNSDFjRS8zanFrMFZjWDNMbDVuTmxxdzhRaGd0WC9JcElZY20z?= =?utf-8?B?Q3MrdVN0Mzg1NmZiejdMQjJRUXJRNmNiYVJaNkpOaXVZV3JwdVdiYzdsV21Q?= =?utf-8?B?SnUyd1M4N0Vja0NSN2lXUWk2NXVjUmNqRXp0MVkvT3BZY3JUYnAvMkFPV0Nx?= =?utf-8?B?OVlHd0h4ZExwaUtsNHp2dkhjci9iaU5hQkM3ZmI3eC9JaW5KVWUrWUlUZGxG?= =?utf-8?B?cmtQSENINldkUDR0VVhGaXVsMWZZR0oyTFBDQXUxVjB2b09VOVhyejViQWNa?= =?utf-8?B?bjdkZkZMa2ZQMjJ4KzBvQnZWenRReE1HYVRlY0Z0TDZrMlZGdDg3RFR6ZjJG?= =?utf-8?B?eHk2aGFFNU9GR1l2YUI3M1Y4NWlLZjUwMDQ0SWllcXVPRWdrM2t2SVBCNDIz?= =?utf-8?B?NVVYbUZaVDJ6ZjYxaithRFVhVHB0UWtuYkNOUnZyM2h2cStrVXg3ZjdGT0RK?= =?utf-8?B?M0w1SXR2M1ludWFQejN3TFdOZEZyWnZDdWlWT3dLL2gzQTFVTzl0dUxZOVM5?= =?utf-8?B?QlBpdlQ5MFp2RU01QTlXcDBOUEhwU0dFRWQxN0xFSE56RkpuTngzRnNBOUp2?= =?utf-8?B?K1BrY0puVEt3SDZKdFZtN0lTaGVXNDVsT1MvRG0xY1VJc0JIU3M5TElzVVhH?= =?utf-8?B?aEZIQ3drdDhYQ3VsdVNlU2VjV2RPTGFVSnowMEFnTU01aWZubFpmYTBhMDRQ?= =?utf-8?B?UUYwU04rRHNpRXZZQTNGb1MvVjdlNzlkNmZYSHJCek90SFE2ZXdjcjNGR3ZW?= =?utf-8?B?T0orZWhtSlhBK3poSGtZQlFkZUdFOEUxaTlXYWs3NVZtSFRyWExvTVgzWUNz?= =?utf-8?B?ejNDUG1TVlY0aE5uSkZWeXFDcThiN2pBK3Q4WEZyeitVaU40UE91T0thRUtD?= =?utf-8?B?NHdhSisrNWdMY2xDWkxZdWRiUW41R2N3cTJxbE0wanpMRlJ3Wkc0NDM5bFZK?= =?utf-8?B?MFZnd1Z3SE83QkNGdGpvWElHYjFzVFNaUXF2WGZkeSs3TzkvRkpkNlAvT2J5?= =?utf-8?B?cnNvckhLRDRBWjk0TkluUndkMklNRW5OMXpmM2VMQXlhVFNCc3VudE9YWmlH?= =?utf-8?B?amE2d2JyZUVTMEcvN2xUUVNUM1V5amdRdk02N2l5ZmdPaXEyUjN6NEV4OGNq?= =?utf-8?B?Z1R6S05pSUtaVGtFWVNzVUptbm9UenUyMHg2SFpZV2JCN21KTmpwOGpKSXJ5?= =?utf-8?B?R2Z1Sm53VnkxQlMxRUoxNE9TVDVXcXlEL3k3UFFpMU9TZXI5RVo2RlR0VnBE?= =?utf-8?B?cS81TGp2amU4ZjNadjlyRUg5WmcxTjJZZlc3M2pobGlFUG1LQ0g5OE5oVGkv?= =?utf-8?B?eW4veXkwTjFRSU5NTnBqdWhLQlRFWmp5R3FqamJkd3o0RVBBUDNvaXRTekJN?= =?utf-8?B?QWl6SzhWR2FhMlB0UWRFMzBEQllHMXRDazZQMFJ3Ty9Jb2NocXl5NzZsTnZ4?= =?utf-8?B?T3o5UE5sS0VoZHp3cWZQN1hIdzhVbG5rdFF5MlJWZ1FBUHIxTXZMN1ZxTDVS?= =?utf-8?Q?jfzjYN/P8Lz9REmRdOBS4NwIM?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a39d3ffb-1562-4d50-a78c-08db134b2313 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2023 14:02:43.7209 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y2ziGLir1aKOmkqIL6Ok1lXxcs5S8lvnRotRgSf9LnFbnd1yaYU4LW+ICDBx8kD2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8744 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/20/2023 9:02 AM, Chaoyong He wrote: > From: Peng Zhang > > Initializing of the NFP PMD fails when a NFDk device is used in a PCIe > slot that supports 48-bit DMA address. The failure is due to an > incorrect check by the PMD that limits the support to 40-bit DMA > address. While this check is correct for NFD3 devices, it is incorrect > for NFDk that can support 48-bit DMA address. > > Fix this by correcting the DMA mask check at initialization to allow for > different DMA address masks for NFD3 and NFDk. > > The RX free list descriptor code is also updated to allow for 48-bit DMA > address. While this code is shared by the NFD3 and NFDk code paths, > this is not an issue as for 40-bit address the top bits are always 0. > > Fixes: c73dced48c8c ("net/nfp: add NFDk Tx") > Cc: jin.liu@corigine.com > Cc: stable@dpdk.org > > Signed-off-by: Peng Zhang > Reviewed-by: Chaoyong He > Reviewed-by: Niklas Söderlund Applied to dpdk-next-net/main, thanks.